Review Request 121038: Convert language/ to new signal slot syntax

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121038/#review70059
-----------------------------------------------------------



language/assistant/renameassistant.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49017>

    remove ()



language/assistant/staticassistantsmanager.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49018>

    remove ()



language/assistant/staticassistantsmanager.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49019>

    here and below: whitespace after ]



language/assistant/staticassistantsmanager.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49020>

    that looks OK though. the signal is emitted per-line. see also language/backgroundparser/documentchangetracker.cpp



language/highlighting/codehighlighting.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49021>

    this signal should be added to the public interface.



language/util/navigationtooltip.cpp
<https://git.reviewboard.kde.org/r/121038/#comment49023>

    if !widget but m_navigationWidget, this should still set the navigation widget to nullptr and disconnect.


- Milian Wolff


On Nov. 7, 2014, 5:34 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121038/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Convert language/ to new signal slot syntax
> 
> 
> Diffs
> -----
> 
>   language/assistant/renameassistant.h d9f856e481c6b7260bf696fdc3a5f69e96d28bd1 
>   language/assistant/renameassistant.cpp cbc4409965676adf88245dce2e3556b17e6b22fb 
>   language/assistant/staticassistantsmanager.h e17a54134731444a086f0793f59afbd246ec5498 
>   language/assistant/staticassistantsmanager.cpp 7e9e0bf57bcdf9c7e904742de2735c6979c39aa6 
>   language/backgroundparser/backgroundparser.cpp 2cec6a05658fe482a4417e21d3da6d81482013ef 
>   language/backgroundparser/documentchangetracker.cpp 8d71a8b8f0b68b2ce7de34e41796eba7130d868c 
>   language/backgroundparser/parseprojectjob.cpp 3a59e1695f34835459092785934ab8c07f268d69 
>   language/backgroundparser/tests/test_backgroundparser.h bcc77a514e29ee96b8dae5fc200663b43276b28d 
>   language/backgroundparser/tests/test_backgroundparser.cpp 2ef870f98793e88d81fb1fda1f7e176f6fb1d609 
>   language/codecompletion/codecompletion.cpp b32caa41f8d4e368ad93f0463c461bc57afc28bd 
>   language/codecompletion/codecompletionmodel.cpp a2d1a3d3d2881f7fa47523b51121dbb9c0ff29f3 
>   language/codegen/applychangeswidget.cpp cb3a5c73a621ea6b6abed5673673a2b079ffc55f 
>   language/codegen/basicrefactoring.cpp ddce07ed6efb963a7eda65c06f57fcc3085a66fa 
>   language/codegen/progressdialogs/refactoringdialog.cpp 2d00c8fac394742d9f0c3996cdd1126f400d7f51 
>   language/duchain/duchain.cpp 8e84a30300309f0dbd84f846bb6a62babbd923f2 
>   language/duchain/navigation/abstractdeclarationnavigationcontext.cpp d9054497ed4fcd0648a3aeb7fe7d5b7d42574d12 
>   language/duchain/navigation/abstractnavigationwidget.cpp fcc0566685852f2a902f5923f617624deecc44c5 
>   language/duchain/navigation/useswidget.cpp 15e84d9e827768ceba3a321ba73ad30872992af7 
>   language/duchain/tests/test_duchain.cpp 6a6065702ce6ba64d95de869c57d050f03d959d4 
>   language/editor/persistentmovingrangeprivate.cpp 9ece0898d2f6614413a2aebca65d2cf2dec950fe 
>   language/highlighting/codehighlighting.cpp b33b8536d56a089924cae76033267b518e22a3bb 
>   language/highlighting/colorcache.cpp 2c6338aacdce3cc1b9f28a7c5d99d319626cc049 
>   language/util/navigationtooltip.h 1a8decdc7b11100575d407964d0994f3cb6131b4 
>   language/util/navigationtooltip.cpp d3f2554fff4a1236f8bbbfebac8da4ab567cf898 
> 
> Diff: https://git.reviewboard.kde.org/r/121038/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/a2f13a0e/attachment.html>