<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121038/">https://git.reviewboard.kde.org/r/121038/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326741#file326741line217" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/renameassistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void RenameAssistant::textChanged(KTextEditor::View* view, const KTextEditor::Range& invocationRange, const QString& removedText)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">217</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">executed</span></span><span class="p"><span class="hl">(</span></span><span class="n">IAssistantAction</span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">reset</span><span class="p">()<span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">217</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="o"><span class="hl">&</span></span><span class="n">IAssistantAction</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">executed</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">reset</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove ()</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326743#file326743line88" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/staticassistantsmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct StaticAssistantsManager::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">m_timer</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">timeout</span><span class="p">()),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">timeout</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">m_timer</span><span class="p">,</span> <span class="o">&</span><span class="n">QTimer</span><span class="o">::</span><span class="n">timeout</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="p">[</span><span class="o">&</span><span class="p">]()</span> <span class="p">{</span> <span class="n">d</span><span class="o">-></span><span class="n">timeout</span><span class="p">();</span> <span class="p">});</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove ()</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326743#file326743line92" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/staticassistantsmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct StaticAssistantsManager::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SLOT</span><span class="p">(</span><span class="n">documentLoaded</span><span class="p">(</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">IDocument</span><span class="o">*</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="p">,</span> <span class="p">[</span><span class="o">&</span><span class="p">](</span><span class="n">IDocument</span><span class="o">*</span> <span class="n">document</span><span class="p">)</span> <span class="p">{</span> <span class="n">d</span><span class="o">-></span><span class="n">documentLoaded</span><span class="p">(</span><span class="n">document</span><span class="p">);</span> <span class="p">});</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here and below: whitespace after ]</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326743#file326743line151" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/staticassistantsmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<StaticAssistant::Ptr> StaticAssistantsManager::registeredAssistants() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_eventualRange</span> <span class="o">=</span> <span class="n">Range</span><span class="p">(</span><span class="n">cursor</span><span class="p">,</span> <span class="n">text</span><span class="p">.</span><span class="n">size</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that looks OK though. the signal is emitted per-line. see also language/backgroundparser/documentchangetracker.cpp</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326760#file326760line498" style="color: black; font-weight: bold; text-decoration: underline;">language/highlighting/codehighlighting.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CodeHighlighting::applyHighlighting(void* _highlighting)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">498</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#pragma message("TODO: this depends on the implemenation of katedocument.h, is that okay?")</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this signal should be added to the public interface.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121038/diff/1/?file=326763#file326763line46" style="color: black; font-weight: bold; text-decoration: underline;">language/util/navigationtooltip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NavigationToolTip::sizeHintChanged() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if !widget but m_navigationWidget, this should still set the navigation widget to nullptr and disconnect.</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 7th, 2014, 5:34 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert language/ to new signal slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/assistant/renameassistant.h <span style="color: grey">(d9f856e481c6b7260bf696fdc3a5f69e96d28bd1)</span></li>
<li>language/assistant/renameassistant.cpp <span style="color: grey">(cbc4409965676adf88245dce2e3556b17e6b22fb)</span></li>
<li>language/assistant/staticassistantsmanager.h <span style="color: grey">(e17a54134731444a086f0793f59afbd246ec5498)</span></li>
<li>language/assistant/staticassistantsmanager.cpp <span style="color: grey">(7e9e0bf57bcdf9c7e904742de2735c6979c39aa6)</span></li>
<li>language/backgroundparser/backgroundparser.cpp <span style="color: grey">(2cec6a05658fe482a4417e21d3da6d81482013ef)</span></li>
<li>language/backgroundparser/documentchangetracker.cpp <span style="color: grey">(8d71a8b8f0b68b2ce7de34e41796eba7130d868c)</span></li>
<li>language/backgroundparser/parseprojectjob.cpp <span style="color: grey">(3a59e1695f34835459092785934ab8c07f268d69)</span></li>
<li>language/backgroundparser/tests/test_backgroundparser.h <span style="color: grey">(bcc77a514e29ee96b8dae5fc200663b43276b28d)</span></li>
<li>language/backgroundparser/tests/test_backgroundparser.cpp <span style="color: grey">(2ef870f98793e88d81fb1fda1f7e176f6fb1d609)</span></li>
<li>language/codecompletion/codecompletion.cpp <span style="color: grey">(b32caa41f8d4e368ad93f0463c461bc57afc28bd)</span></li>
<li>language/codecompletion/codecompletionmodel.cpp <span style="color: grey">(a2d1a3d3d2881f7fa47523b51121dbb9c0ff29f3)</span></li>
<li>language/codegen/applychangeswidget.cpp <span style="color: grey">(cb3a5c73a621ea6b6abed5673673a2b079ffc55f)</span></li>
<li>language/codegen/basicrefactoring.cpp <span style="color: grey">(ddce07ed6efb963a7eda65c06f57fcc3085a66fa)</span></li>
<li>language/codegen/progressdialogs/refactoringdialog.cpp <span style="color: grey">(2d00c8fac394742d9f0c3996cdd1126f400d7f51)</span></li>
<li>language/duchain/duchain.cpp <span style="color: grey">(8e84a30300309f0dbd84f846bb6a62babbd923f2)</span></li>
<li>language/duchain/navigation/abstractdeclarationnavigationcontext.cpp <span style="color: grey">(d9054497ed4fcd0648a3aeb7fe7d5b7d42574d12)</span></li>
<li>language/duchain/navigation/abstractnavigationwidget.cpp <span style="color: grey">(fcc0566685852f2a902f5923f617624deecc44c5)</span></li>
<li>language/duchain/navigation/useswidget.cpp <span style="color: grey">(15e84d9e827768ceba3a321ba73ad30872992af7)</span></li>
<li>language/duchain/tests/test_duchain.cpp <span style="color: grey">(6a6065702ce6ba64d95de869c57d050f03d959d4)</span></li>
<li>language/editor/persistentmovingrangeprivate.cpp <span style="color: grey">(9ece0898d2f6614413a2aebca65d2cf2dec950fe)</span></li>
<li>language/highlighting/codehighlighting.cpp <span style="color: grey">(b33b8536d56a089924cae76033267b518e22a3bb)</span></li>
<li>language/highlighting/colorcache.cpp <span style="color: grey">(2c6338aacdce3cc1b9f28a7c5d99d319626cc049)</span></li>
<li>language/util/navigationtooltip.h <span style="color: grey">(1a8decdc7b11100575d407964d0994f3cb6131b4)</span></li>
<li>language/util/navigationtooltip.cpp <span style="color: grey">(d3f2554fff4a1236f8bbbfebac8da4ab567cf898)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>