Review Request 121043: convert shell/ to new signal/slot syntax

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121043/#review70052
-----------------------------------------------------------

Ship it!



shell/core.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49002>

    maybe instead do
    
        auto connected = connect(...);
        Q_ASSERT(connected);
        Q_UNUSED(connected);
    
    then again, we don't do these explicit checks anywhere else. And Qt warns about broken connects on the CLI. When you set the QT_FATAL_WARNINGS=1 env var, you'll also get an assertion then which you can spot with GDB. so maybe just remove this line again?



shell/documentcontroller.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49003>

    style: whitespace after ] and what Kevin said



shell/documentcontroller.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49004>

    remove `()`



shell/project.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49005>

    whitespace after ], also below



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49006>

    just catch &, style again here and below: remove `()`



shell/runcontroller.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49007>

    remove `()`



shell/runcontroller.cpp
<https://git.reviewboard.kde.org/r/121043/#comment49008>

    whitespace after ]


- Milian Wolff


On Nov. 7, 2014, 5:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121043/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> convert shell/ to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   shell/statusbar.cpp 81356d2129b4fb83d472429452c6ddd7e47447af 
>   shell/textdocument.h 7f353f4c320d6687c6a0ee749c9d89ea84cef0d4 
>   shell/textdocument.cpp 719ceeaf9a0682c2baad8373c000a7a358e7a224 
>   shell/uicontroller.cpp 43638a9fe9605ee48006a40c91a20d412e03047b 
>   shell/workingsetcontroller.cpp 2c3b850b7743510ae068802cdf536f2628953e1f 
>   shell/workingsets/closedworkingsetswidget.cpp cdbe303c4d684dae208ef4f750364f3e245eefa2 
>   shell/workingsets/workingset.h 8d1e0f5a918cf6cf652233bf59e57931f622b20a 
>   shell/workingsets/workingset.cpp fcb8c40286f5b44b646a5e98bb0666cccb185cc1 
>   shell/workingsets/workingsettoolbutton.cpp af64aed83dd811b9621e871922cf042729c6cf01 
>   shell/workingsets/workingsettooltipwidget.cpp b029663dd8e22ffcda7ae29bd04eb093685fa8fa 
>   shell/workingsets/workingsetwidget.cpp 1749cd1cffa518aa79f7dd3bc3a8c2700a98427c 
>   shell/areadisplay.cpp 55fde59cfe48e6bb17c79b23e006e1da7d779d88 
>   shell/assistantpopup.cpp 7ad9b154cdadac0d271b6f07dbb2c2eb7195d487 
>   shell/core.cpp 6f6c2eb23fbc5a78429d54ed1d74e316d4ff93e0 
>   shell/debugcontroller.cpp 8546a5339b655c528cdf8ccace31054f31ced0d5 
>   shell/documentationcontroller.cpp b702927a53128a247ebdc50c94ba9d9cd5ffbe8d 
>   shell/documentcontroller.cpp 754d3b46399fd17b54127ee21caec1b28b0088e8 
>   shell/languagecontroller.cpp 5245702c16dc994ef11387d7b152f1db8f549ac4 
>   shell/launchconfigurationdialog.cpp f340dc986867b1324c77a743aae61c98bc67a85d 
>   shell/loadedpluginsdialog.cpp ccfd1b8ca8495df30ca35c35945bffae0eef47bf 
>   shell/mainwindow.cpp 94f2aee2bde6badc1d388e780bdadc513c466c6e 
>   shell/mainwindow_p.cpp 1a7d218bfa0758753fa6313ba6371c38cc2a5ba6 
>   shell/openprojectdialog.cpp d89dd397fcf182f0d23e9b4d91ea447582443930 
>   shell/openprojectpage.h b614b851ade4442e90b912a0c6e2b8deb2757951 
>   shell/openprojectpage.cpp b07d5782eb50b87fc652516f40569ddbf503c5f6 
>   shell/progresswidget/progressdialog.cpp a0607173ca15f9cd120d2a2c074609fb3e13e792 
>   shell/progresswidget/progressmanager.cpp d8903e1b2319c705af5ed9ae523666b3092574ab 
>   shell/progresswidget/statusbarprogresswidget.cpp 3304584311fa20a50fb6cef80359e2571dd12394 
>   shell/project.cpp 2a6e4acff3f7cc74753837be320f2142239c9d1b 
>   shell/projectcontroller.cpp c8f520c121d7b9da5998fa3a9e8b3f1cbd34a164 
>   shell/projectinfopage.cpp 9c12d0635196e63bcd709627fec1aa8feac056e9 
>   shell/projectsourcepage.cpp 447f628d0e508421696b35cdef7632133bf98347 
>   shell/runcontroller.cpp 153a4b11bdea1364dabfdf22700fbe8ad8a4be2b 
>   shell/savedialog.cpp cad02a9c2953c89c500d3df1aebe8e2dee5081af 
>   shell/sessionchooserdialog.cpp 0ad17f98c96ef7ea0697de5cf7792dd3f48086e2 
>   shell/sessioncontroller.cpp 5a76c8bd4dda2636eff85cddd9789946849eed5d 
>   shell/sessiondialog.cpp 9c770afd37c9fa5277677a19627ec425ff450814 
>   shell/settings/editstyledialog.cpp 8a08c43fc17242bced93bc9ccea55012a84b80cc 
>   shell/settings/environmentpreferences.cpp d663bc363ec847fcab677680b14d9c7cbd6369b3 
>   shell/settings/environmentwidget.cpp 6d7c3c980c09558b75191b49b014295d3c7f87bc 
>   shell/settings/pluginpreferences.cpp 0c930961ed55b64fccd56f611cfd48b5a99eb55e 
>   shell/settings/sourceformattersettings.cpp 982d114e04b7d8eab7e986cc465ef8bb7086f288 
>   shell/sourceformattercontroller.cpp 004405a2d47358b81655f402be44c3f6d5779c74 
> 
> Diff: https://git.reviewboard.kde.org/r/121043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/2d61c14b/attachment-0001.html>