<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121043/">https://git.reviewboard.kde.org/r/121043/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326804#file326804line330" style="color: black; font-weight: bold; text-decoration: underline;">shell/core.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Core::initialize(QObject* splash, Setup mode, const QString& session )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">330</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">splash</span><span class="o">-></span><span class="n">metaObject</span><span class="p">()</span><span class="o">-></span><span class="n">indexOfSlot</span><span class="p">(</span><span class="n">SLOT</span><span class="p">(</span><span class="n">progress</span><span class="p">(</span><span class="kt">int</span><span class="p">)))</span> <span class="o">!=</span> <span class="o">-</span><span class="mi">1</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe instead do</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">auto</span> connected <span style="color: #666666">=</span> connect(...);
Q_ASSERT(connected);
Q_UNUSED(connected);
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">then again, we don't do these explicit checks anywhere else. And Qt warns about broken connects on the CLI. When you set the QT_FATAL_WARNINGS=1 env var, you'll also get an assertion then which you can spot with GDB. so maybe just remove this line again?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326807#file326807line568" style="color: black; font-weight: bold; text-decoration: underline;">shell/documentcontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">DocumentController::DocumentController( QObject *parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">568</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">documentUrlChanged</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n">IDocument</span><span class="o">*</span><span class="p"><span class="hl">)),</span></span> <span class="k">this</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">changeDocumentUrl</span><span class="p">(</span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">ID</span>ocument</span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">)));</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">568</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">DocumentController</span></span><span class="o"><span class="hl">::</span></span><span class="n">documentUrlChanged</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">](</span></span><span class="n">IDocument</span><span class="o">*</span><span class="hl"> </span><span class="n"><span class="hl">document</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span> <span class="k">this</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">changeDocumentUrl</span><span class="p">(</span><span class="n"><span class="hl">d</span>ocument</span><span class="p"><span class="hl">);</span></span><span class="hl"> </span><span class="p"><span class="hl">});</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">style: whitespace after ] and what Kevin said</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326807#file326807line603" style="color: black; font-weight: bold; text-decoration: underline;">shell/documentcontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DocumentController::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">603</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">action</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">triggered</span><span class="p"><span class="hl">(</span></span><span class="kt"><span class="hl">bool</span></span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">chooseDocument</span><span class="p">()<span class="hl">)</span></span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">603</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">action</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">QAction</span></span><span class="o"><span class="hl">::</span></span><span class="n">triggered</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">chooseDocument</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">()</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326819#file326819line492" style="color: black; font-weight: bold; text-decoration: underline;">shell/project.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Project::reloadModel()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">492</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">job</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">finished</span><span class="p">(</span><span class="n">KJob</span><span class="o">*</span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">reloadDone</span><span class="p">(</span><span class="n"><span class="hl">KJob</span></span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">)));</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">492</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">job</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">KJob</span></span><span class="o"><span class="hl">::</span></span><span class="n">finished</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]</span>(</span><span class="n">KJob</span><span class="o">*</span><span class="hl"> </span><span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">reloadDone</span><span class="p">(</span><span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">);</span></span><span class="hl"> </span><span class="p"><span class="hl">});</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">whitespace after ], also below</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326820#file326820line504" style="color: black; font-weight: bold; text-decoration: underline;">shell/projectcontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ProjectController::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">504</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">action</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">triggered</span><span class="p"><span class="hl">(</span></span><span class="kt"><span class="hl">bool</span></span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">openProject</span><span class="p">()<span class="hl">)</span></span><span class="hl"> </span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">504</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">QAction</span></span><span class="o"><span class="hl">::</span></span><span class="n">triggered</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n">openProject</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just catch &, style again here and below: remove <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">()</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326823#file326823line424" style="color: black; font-weight: bold; text-decoration: underline;">shell/runcontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void RunController::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">424</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">triggered</span><span class="p"><span class="hl">(</span></span><span class="kt"><span class="hl">bool</span></span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">configureLaunches</span><span class="p">()<span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">424</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">QAction</span></span><span class="o"><span class="hl">::</span></span><span class="n">triggered</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">configureLaunches</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">()</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121043/diff/1/?file=326823#file326823line923" style="color: black; font-weight: bold; text-decoration: underline;">shell/runcontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QItemDelegate * KDevelop::RunController::delegate() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">923</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">launchAsMapper</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">mapped</span><span class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">launchAs</span><span class="p">(</span><span class="kt">int</span><span class="p">))</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">923</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">launchAsMapper</span><span class="p">,</span> <span class="k">static_cast</span><span class="o"><</span><span class="kt">void</span><span class="p">(</span><span class="n">QSignalMapper</span><span class="o">::*</span><span class="p">)(</span><span class="kt">int</span><span class="p">)</span><span class="o">></span><span class="p">(</span><span class="o">&</span><span class="n">QSignalMapper</span><span class="o">::</span><span class="n">mapped</span><span class="p">),</span> <span class="k">this</span><span class="p">,</span> <span class="p">[</span><span class="o">&</span><span class="p">](</span><span class="kt">int</span> <span class="n">id</span><span class="p">)</span> <span class="p">{</span> <span class="n">d</span><span class="o">-></span><span class="n">launchAs</span><span class="p">(</span><span class="n">id</span><span class="p">);</span> <span class="p">}</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">whitespace after ]</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 7th, 2014, 5:35 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">convert shell/ to new signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/statusbar.cpp <span style="color: grey">(81356d2129b4fb83d472429452c6ddd7e47447af)</span></li>
<li>shell/textdocument.h <span style="color: grey">(7f353f4c320d6687c6a0ee749c9d89ea84cef0d4)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(719ceeaf9a0682c2baad8373c000a7a358e7a224)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(43638a9fe9605ee48006a40c91a20d412e03047b)</span></li>
<li>shell/workingsetcontroller.cpp <span style="color: grey">(2c3b850b7743510ae068802cdf536f2628953e1f)</span></li>
<li>shell/workingsets/closedworkingsetswidget.cpp <span style="color: grey">(cdbe303c4d684dae208ef4f750364f3e245eefa2)</span></li>
<li>shell/workingsets/workingset.h <span style="color: grey">(8d1e0f5a918cf6cf652233bf59e57931f622b20a)</span></li>
<li>shell/workingsets/workingset.cpp <span style="color: grey">(fcb8c40286f5b44b646a5e98bb0666cccb185cc1)</span></li>
<li>shell/workingsets/workingsettoolbutton.cpp <span style="color: grey">(af64aed83dd811b9621e871922cf042729c6cf01)</span></li>
<li>shell/workingsets/workingsettooltipwidget.cpp <span style="color: grey">(b029663dd8e22ffcda7ae29bd04eb093685fa8fa)</span></li>
<li>shell/workingsets/workingsetwidget.cpp <span style="color: grey">(1749cd1cffa518aa79f7dd3bc3a8c2700a98427c)</span></li>
<li>shell/areadisplay.cpp <span style="color: grey">(55fde59cfe48e6bb17c79b23e006e1da7d779d88)</span></li>
<li>shell/assistantpopup.cpp <span style="color: grey">(7ad9b154cdadac0d271b6f07dbb2c2eb7195d487)</span></li>
<li>shell/core.cpp <span style="color: grey">(6f6c2eb23fbc5a78429d54ed1d74e316d4ff93e0)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(8546a5339b655c528cdf8ccace31054f31ced0d5)</span></li>
<li>shell/documentationcontroller.cpp <span style="color: grey">(b702927a53128a247ebdc50c94ba9d9cd5ffbe8d)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(754d3b46399fd17b54127ee21caec1b28b0088e8)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(5245702c16dc994ef11387d7b152f1db8f549ac4)</span></li>
<li>shell/launchconfigurationdialog.cpp <span style="color: grey">(f340dc986867b1324c77a743aae61c98bc67a85d)</span></li>
<li>shell/loadedpluginsdialog.cpp <span style="color: grey">(ccfd1b8ca8495df30ca35c35945bffae0eef47bf)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(94f2aee2bde6badc1d388e780bdadc513c466c6e)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(1a7d218bfa0758753fa6313ba6371c38cc2a5ba6)</span></li>
<li>shell/openprojectdialog.cpp <span style="color: grey">(d89dd397fcf182f0d23e9b4d91ea447582443930)</span></li>
<li>shell/openprojectpage.h <span style="color: grey">(b614b851ade4442e90b912a0c6e2b8deb2757951)</span></li>
<li>shell/openprojectpage.cpp <span style="color: grey">(b07d5782eb50b87fc652516f40569ddbf503c5f6)</span></li>
<li>shell/progresswidget/progressdialog.cpp <span style="color: grey">(a0607173ca15f9cd120d2a2c074609fb3e13e792)</span></li>
<li>shell/progresswidget/progressmanager.cpp <span style="color: grey">(d8903e1b2319c705af5ed9ae523666b3092574ab)</span></li>
<li>shell/progresswidget/statusbarprogresswidget.cpp <span style="color: grey">(3304584311fa20a50fb6cef80359e2571dd12394)</span></li>
<li>shell/project.cpp <span style="color: grey">(2a6e4acff3f7cc74753837be320f2142239c9d1b)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(c8f520c121d7b9da5998fa3a9e8b3f1cbd34a164)</span></li>
<li>shell/projectinfopage.cpp <span style="color: grey">(9c12d0635196e63bcd709627fec1aa8feac056e9)</span></li>
<li>shell/projectsourcepage.cpp <span style="color: grey">(447f628d0e508421696b35cdef7632133bf98347)</span></li>
<li>shell/runcontroller.cpp <span style="color: grey">(153a4b11bdea1364dabfdf22700fbe8ad8a4be2b)</span></li>
<li>shell/savedialog.cpp <span style="color: grey">(cad02a9c2953c89c500d3df1aebe8e2dee5081af)</span></li>
<li>shell/sessionchooserdialog.cpp <span style="color: grey">(0ad17f98c96ef7ea0697de5cf7792dd3f48086e2)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(5a76c8bd4dda2636eff85cddd9789946849eed5d)</span></li>
<li>shell/sessiondialog.cpp <span style="color: grey">(9c770afd37c9fa5277677a19627ec425ff450814)</span></li>
<li>shell/settings/editstyledialog.cpp <span style="color: grey">(8a08c43fc17242bced93bc9ccea55012a84b80cc)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(d663bc363ec847fcab677680b14d9c7cbd6369b3)</span></li>
<li>shell/settings/environmentwidget.cpp <span style="color: grey">(6d7c3c980c09558b75191b49b014295d3c7f87bc)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(0c930961ed55b64fccd56f611cfd48b5a99eb55e)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(982d114e04b7d8eab7e986cc465ef8bb7086f288)</span></li>
<li>shell/sourceformattercontroller.cpp <span style="color: grey">(004405a2d47358b81655f402be44c3f6d5779c74)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>