Review Request 121042: convert vcs/ to new signal/slot syntax

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121042/#review70050
-----------------------------------------------------------

Ship it!


note: while I'm picky, please be aware that I'm immensely grateful for your contributions! Thanks a million for spending your time on such mundane (but worthwhile!) jobs. You do deserve a beer whenever I have the pleasure to meet you in person :)


vcs/models/vcsannotationmodel.cpp
<https://git.reviewboard.kde.org/r/121042/#comment48997>

    style: whitespace after ]



vcs/models/vcseventmodel.cpp
<https://git.reviewboard.kde.org/r/121042/#comment48998>

    style: remove ()



vcs/widgets/vcsdiffwidget.cpp
<https://git.reviewboard.kde.org/r/121042/#comment48999>

    whitespace; remove `this`



vcs/widgets/vcseventwidget.cpp
<https://git.reviewboard.kde.org/r/121042/#comment49000>

    space



vcs/widgets/vcseventwidget.cpp
<https://git.reviewboard.kde.org/r/121042/#comment49001>

    whitespace; `this` - also below


- Milian Wolff


On Nov. 7, 2014, 5:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121042/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> convert vcs/ to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.cpp c88e3c895babcb4bee91d6fbca200b9de9c6a148 
>   vcs/dvcs/ui/branchmanager.cpp b961c6e4c876b39f7daadfebb99c146a15b26592 
>   vcs/dvcs/ui/dvcsimportmetadatawidget.cpp d36d8081cc3c4977c34e8ecdd793cc9a848f3090 
>   vcs/interfaces/icontentawareversioncontrol.cpp 4d25daefe035ddc6eb65602fa6ed74f6f32fa865 
>   vcs/models/brancheslistmodel.cpp 5f16c9deafd21aae41b110a0398282e67cd0de43 
>   vcs/models/projectchangesmodel.cpp cc1f8f6784052974aebf04f0742cd3a9b78a8d2d 
>   vcs/models/vcsannotationmodel.cpp 27c1f7bef88d7c49bde53fe7ad3f797fd29a6d3a 
>   vcs/models/vcseventmodel.cpp fa2005ae2c0cdbcfa4b7860d3c7bd86e302e3336 
>   vcs/vcspluginhelper.cpp 19cc0fc4b6fe19496237443db33bbb3d525dc747 
>   vcs/widgets/flexibleaction.cpp 2009fa1f39150423d4b8bcd5249f567025d9012b 
>   vcs/widgets/standardvcslocationwidget.cpp e0f044ce4ba4f15d6d616e6cc029704490ae9a6f 
>   vcs/widgets/vcscommitdialog.cpp fff340b04c388d495a4868dad28bc8bd5fb5805a 
>   vcs/widgets/vcsdiffpatchsources.cpp 9f7c6b5fd908136a9628c77fdc584f4e28934178 
>   vcs/widgets/vcsdiffwidget.cpp 1ec294c26b06c24c6a36587b46300a406650c310 
>   vcs/widgets/vcseventwidget.cpp e5c019921853a82883c064f763b8cb14d0c5a00b 
> 
> Diff: https://git.reviewboard.kde.org/r/121042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/77014bd7/attachment-0001.html>