<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121042/">https://git.reviewboard.kde.org/r/121042/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">note: while I'm picky, please be aware that I'm immensely grateful for your contributions! Thanks a million for spending your time on such mundane (but worthwhile!) jobs. You do deserve a beer whenever I have the pleasure to meet you in person :)</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121042/diff/1/?file=326793#file326793line89" style="color: black; font-weight: bold; text-decoration: underline;">vcs/models/vcsannotationmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">VcsAnnotationModel::VcsAnnotationModel(VcsJob *job, const QUrl& url, QObject* parent,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">job</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">resultsReady</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n">VcsJob</span><span class="o">*</span><span class="p"><span class="hl">)),</span></span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">addLines</span><span class="p">(</span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">VcsJob</span></span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">))</span></span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">job</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">VcsJob</span></span><span class="o"><span class="hl">::</span></span><span class="n">resultsReady</span><span class="p"><span class="hl">,</span></span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">](</span></span><span class="n">VcsJob</span><span class="o">*</span><span class="hl"> </span><span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">addLines</span><span class="p">(</span><span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">);</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">style: whitespace after ]</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121042/diff/1/?file=326794#file326794line153" style="color: black; font-weight: bold; text-decoration: underline;">vcs/models/vcseventmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool VcsEventModel::canFetchMore(const QModelIndex& parent) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">153</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="k">this</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">destroyed</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QObject</span></span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">))</span>,</span> <span class="n">job</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">kill</span><span class="p">()<span class="hl">)</span></span><span class="hl"> </span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">153</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">VcsEventModel</span></span><span class="o"><span class="hl">::</span></span><span class="n">destroyed</span><span class="p">,</span> <span class="n">job</span><span class="p">,</span> <span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">job</span></span><span class="o"><span class="hl">-></span></span><span class="n">kill</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">style: remove ()</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121042/diff/1/?file=326800#file326800line91" style="color: black; font-weight: bold; text-decoration: underline;">vcs/widgets/vcsdiffwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">diffReady</span><span class="p">(</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">VcsJob</span><span class="o">*</span><span class="p">))</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="p">,</span> <span class="p">[</span><span class="o">&</span><span class="p">](</span><span class="n">VcsJob</span><span class="o">*</span> <span class="n">job</span><span class="p">)</span> <span class="p">{</span> <span class="k">this</span><span class="o">-></span><span class="n">d</span><span class="o">-></span><span class="n">diffReady</span><span class="p">(</span><span class="n">job</span><span class="p">);</span> <span class="p">}</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">whitespace; remove <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">this</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121042/diff/1/?file=326801#file326801line62" style="color: black; font-weight: bold; text-decoration: underline;">vcs/widgets/vcseventwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class VcsEventWidgetPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QObject</span><span class="o">::</span><span class="n">connect</span><span class="p">(</span><span class="n">m_copyAction</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">triggered</span><span class="p"><span class="hl">(</span></span><span class="kt"><span class="hl">bool</span></span><span class="p"><span class="hl">))</span>,</span> <span class="n">q</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">copyRevision</span><span class="p">()<span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QObject</span><span class="o">::</span><span class="n">connect</span><span class="p">(</span><span class="n">m_copyAction</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">QAction</span></span><span class="o"><span class="hl">::</span></span><span class="n">triggered</span><span class="p">,</span> <span class="n">q</span><span class="p">,</span> <span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n">copyRevision</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">space</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121042/diff/1/?file=326801#file326801line193" style="color: black; font-weight: bold; text-decoration: underline;">vcs/widgets/vcseventwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">VcsEventWidget::VcsEventWidget( const QUrl& url, const VcsRevision& rev, KDevelop::IBasicVersionControl* iface, QWidget* parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">193</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">eventViewClicked</span><span class="p">(</span><span class="n"><span class="hl">QModelI</span>ndex</span><span class="p">)<span class="hl">)</span></span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">193</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="p">,</span> <span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">](</span></span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">QModelIndex</span></span><span class="o"><span class="hl">&</span></span><span class="hl"> </span><span class="n"><span class="hl">index</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">eventViewClicked</span><span class="p">(</span><span class="n"><span class="hl">i</span>ndex</span><span class="p">)<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">whitespace; <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">this</code> - also below</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 7th, 2014, 5:35 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">convert vcs/ to new signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/dvcs/dvcsjob.cpp <span style="color: grey">(c88e3c895babcb4bee91d6fbca200b9de9c6a148)</span></li>
<li>vcs/dvcs/ui/branchmanager.cpp <span style="color: grey">(b961c6e4c876b39f7daadfebb99c146a15b26592)</span></li>
<li>vcs/dvcs/ui/dvcsimportmetadatawidget.cpp <span style="color: grey">(d36d8081cc3c4977c34e8ecdd793cc9a848f3090)</span></li>
<li>vcs/interfaces/icontentawareversioncontrol.cpp <span style="color: grey">(4d25daefe035ddc6eb65602fa6ed74f6f32fa865)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(5f16c9deafd21aae41b110a0398282e67cd0de43)</span></li>
<li>vcs/models/projectchangesmodel.cpp <span style="color: grey">(cc1f8f6784052974aebf04f0742cd3a9b78a8d2d)</span></li>
<li>vcs/models/vcsannotationmodel.cpp <span style="color: grey">(27c1f7bef88d7c49bde53fe7ad3f797fd29a6d3a)</span></li>
<li>vcs/models/vcseventmodel.cpp <span style="color: grey">(fa2005ae2c0cdbcfa4b7860d3c7bd86e302e3336)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(19cc0fc4b6fe19496237443db33bbb3d525dc747)</span></li>
<li>vcs/widgets/flexibleaction.cpp <span style="color: grey">(2009fa1f39150423d4b8bcd5249f567025d9012b)</span></li>
<li>vcs/widgets/standardvcslocationwidget.cpp <span style="color: grey">(e0f044ce4ba4f15d6d616e6cc029704490ae9a6f)</span></li>
<li>vcs/widgets/vcscommitdialog.cpp <span style="color: grey">(fff340b04c388d495a4868dad28bc8bd5fb5805a)</span></li>
<li>vcs/widgets/vcsdiffpatchsources.cpp <span style="color: grey">(9f7c6b5fd908136a9628c77fdc584f4e28934178)</span></li>
<li>vcs/widgets/vcsdiffwidget.cpp <span style="color: grey">(1ec294c26b06c24c6a36587b46300a406650c310)</span></li>
<li>vcs/widgets/vcseventwidget.cpp <span style="color: grey">(e5c019921853a82883c064f763b8cb14d0c5a00b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121042/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>