Review Request 120963: Convert interfaces/ and outputview/ to new signal slot syntax

[Alexander Richardson]

> On Nov. 3, 2014, 11:40 nachm., Milian Wolff wrote:
> > interfaces/iplugin.cpp, line 109
> > <https://git.reviewboard.kde.org/r/120963/diff/1/?file=325088#file325088line109>
> >
> >     can we remove the private slot `_k_updateState()` from `iplugin.h` now?

I think so. We could also make it a normal private method of IPlugin, which would remove the need for a lambda.


> On Nov. 3, 2014, 11:40 nachm., Milian Wolff wrote:
> > outputview/outputmodel.cpp, line 207
> > <https://git.reviewboard.kde.org/r/120963/diff/1/?file=325091#file325091line207>
> >
> >     why not `model, &OutputModel::linesParsed`? I.e. why is the lambda required here?
> >     
> >     or is this a private slot, then it means the private slot can be removed, no?

Yes, it's a private slot. We could make it a normal private method so that we don't need the lambda.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120963/#review69770
-----------------------------------------------------------


On Nov. 3, 2014, 10:50 nachm., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120963/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 10:50 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Fixes one bad connection in outputjob.cpp
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.cpp 5bc7ada39321e228a4deb618acca8343bae0a38e 
>   interfaces/iplugin.cpp 2b7ae9397f97455bc065f58ef13e6cee2e6e33e8 
>   outputview/outputexecutejob.cpp 3a3b983bc3779ca6676f0b732c10d3499c1fc177 
>   outputview/outputjob.cpp fe9a984f03f9e21a09bc3adf8169ceb908841381 
>   outputview/outputmodel.cpp b7846a24de1eb4ea46356d5b77f6c9a1bdb123a7 
> 
> Diff: https://git.reviewboard.kde.org/r/120963/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141104/eae2a1d5/attachment.html>