<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120963/">https://git.reviewboard.kde.org/r/120963/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2014, 11:40 nachm. CET, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120963/diff/1/?file=325088#file325088line109" style="color: black; font-weight: bold; text-decoration: underline;">interfaces/iplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">IPlugin::IPlugin( const QString &componentName, QObject *parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">108</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span class="k">this</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">_k_updateState</span><span class="p">()<span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">109</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span class="k">this</span><span class="p">,</span> <span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">]()</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n">_k_updateState</span><span class="p">()<span class="hl">;</span></span><span class="hl"> </span><span class="p"><span class="hl">}</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can we remove the private slot <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">_k_updateState()</code> from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">iplugin.h</code> now?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think so. We could also make it a normal private method of IPlugin, which would remove the need for a lambda.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2014, 11:40 nachm. CET, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120963/diff/1/?file=325091#file325091line207" style="color: black; font-weight: bold; text-decoration: underline;">outputview/outputmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">OutputModelPrivate::OutputModelPrivate( OutputModel* model_, const QUrl& builddir)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">207</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">model</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">linesParsed</span></span><span class="p"><span class="hl">(</span></span><span class="n">QVector</span><span class="o"><</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">FilteredItem</span><span class="o">></span><span class="p"><span class="hl">)));</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">207</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">model</span><span class="p">,</span> <span class="p"><span class="hl">[</span></span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">](</span></span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">QVector</span><span class="o"><</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">FilteredItem</span><span class="o">><span class="hl">&</span></span><span class="hl"> </span><span class="n"><span class="hl">items</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span><span class="hl"> </span><span class="n"><span class="hl">model</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">linesParsed</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">items</span></span><span class="p"><span class="hl">);</span></span><span class="hl"> </span><span class="p"><span class="hl">});</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why not <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">model, &OutputModel::linesParsed</code>? I.e. why is the lambda required here?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or is this a private slot, then it means the private slot can be removed, no?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, it's a private slot. We could make it a normal private method so that we don't need the lambda.</p></pre>
<br />
<p>- Alexander</p>
<br />
<p>On November 3rd, 2014, 10:50 nachm. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2014, 10:50 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes one bad connection in outputjob.cpp</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iassistant.cpp <span style="color: grey">(5bc7ada39321e228a4deb618acca8343bae0a38e)</span></li>
<li>interfaces/iplugin.cpp <span style="color: grey">(2b7ae9397f97455bc065f58ef13e6cee2e6e33e8)</span></li>
<li>outputview/outputexecutejob.cpp <span style="color: grey">(3a3b983bc3779ca6676f0b732c10d3499c1fc177)</span></li>
<li>outputview/outputjob.cpp <span style="color: grey">(fe9a984f03f9e21a09bc3adf8169ceb908841381)</span></li>
<li>outputview/outputmodel.cpp <span style="color: grey">(b7846a24de1eb4ea46356d5b77f6c9a1bdb123a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120963/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>