Review Request 118191: Add "batch edit" mode to Defines and Includes GUI

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118191/#review58120
-----------------------------------------------------------


I'm wondering: Why not make this the standard way to edit the entries? Besides completion when doing inline editing I'm not sure there's any important reason to keep a listview instead of allowing the editing through a text editor. The completion could be added to the editor quite easily too.

The only downside could be that its easier to break the entries by accidentally inserting newlines in the middle of a path. However that causes incorrectly parsed source code in the worst case and can be easily fixed once the user notices it. (there could be a warning if there are non-existing paths too).

The buttons would also be removable then, one just needs the browse button for easy access to a file dialog which just adds a new line after the current one.

- Andreas Pakulat


On May 18, 2014, 10:43 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118191/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 10:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Now it's possible to modify many include directories and defined macros at the same time.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 4e512a9 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 1456217 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 4198d65 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui 5542ef4 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp 31feca6 
>   languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp 4df3236 
>   languages/plugins/custom-definesandincludes/kcm_widget/batchedit.ui PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt 0d8c830 
> 
> Diff: https://git.reviewboard.kde.org/r/118191/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/d70d3754-38e4-4f44-9c9a-566bb36f84af__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/af3366d0-23fc-43e3-96e7-f449ac7f987d__after.png
> batch edit.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/53393f2f-4d77-479e-ac9d-0d5383a37247__batch_edit.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140518/5db797a8/attachment.html>