<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118191/">https://git.reviewboard.kde.org/r/118191/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm wondering: Why not make this the standard way to edit the entries? Besides completion when doing inline editing I'm not sure there's any important reason to keep a listview instead of allowing the editing through a text editor. The completion could be added to the editor quite easily too.
The only downside could be that its easier to break the entries by accidentally inserting newlines in the middle of a path. However that causes incorrectly parsed source code in the worst case and can be easily fixed once the user notices it. (there could be a warning if there are non-existing paths too).
The buttons would also be removable then, one just needs the browse button for easy access to a file dialog which just adds a new line after the current one.</pre>
<br />
<p>- Andreas Pakulat</p>
<br />
<p>On May 18th, 2014, 10:43 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated May 18, 2014, 10:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now it's possible to modify many include directories and defined macros at the same time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui <span style="color: grey">(4e512a9)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp <span style="color: grey">(1456217)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h <span style="color: grey">(4198d65)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui <span style="color: grey">(5542ef4)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp <span style="color: grey">(31feca6)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp <span style="color: grey">(4df3236)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/batchedit.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt <span style="color: grey">(0d8c830)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118191/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/d70d3754-38e4-4f44-9c9a-566bb36f84af__before.png">before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/af3366d0-23fc-43e3-96e7-f449ac7f987d__after.png">after.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/53393f2f-4d77-479e-ac9d-0d5383a37247__batch_edit.png">batch edit.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>