Review Request 118070: Support enumerations in plugin.qmltypes files

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118070/#review57675
-----------------------------------------------------------

Ship it!


Seems fine, go for it!

- Sven Brauch


On May 10, 2014, 1:10 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118070/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 1:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch adds support for Enum definitions in plugin.qmltypes files. The support is still minimal because the enumeration is recognized as being an enum, but its values are not yet parsed. An upcoming patch will add support for that, by parsing the "values:" key of Enum definitions.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 212d806 
>   tests/files/plugins.qml 1944023 
> 
> Diff: https://git.reviewboard.kde.org/r/118070/diff/
> 
> 
> Testing
> -------
> 
> This patch adds a test in tests/files/plugins.qml. This test ensures that enumerations are properly recognized and that their declaration and inner context have the proper type. All the other tests still pass.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140510/00e6027f/attachment.html>