Review Request 118070: Support enumerations in plugin.qmltypes files

Denis Steckelmacher steckdenis at yahoo.fr
Sat May 10 13:10:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118070/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdev-qmljs


Description
-------

This patch adds support for Enum definitions in plugin.qmltypes files. The support is still minimal because the enumeration is recognized as being an enum, but its values are not yet parsed. An upcoming patch will add support for that, by parsing the "values:" key of Enum definitions.


Diffs
-----

  duchain/declarationbuilder.cpp 212d806 
  tests/files/plugins.qml 1944023 

Diff: https://git.reviewboard.kde.org/r/118070/diff/


Testing
-------

This patch adds a test in tests/files/plugins.qml. This test ensures that enumerations are properly recognized and that their declaration and inner context have the proper type. All the other tests still pass.


Thanks,

Denis Steckelmacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140510/5486f1f6/attachment.html>


More information about the KDevelop-devel mailing list