Review Request 118032: Reparse the project when includes/defines change (kdevelop)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118032/#review57486
-----------------------------------------------------------

Ship it!


go for it then!


languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp
<https://git.reviewboard.kde.org/r/118032/#comment40004>

    this hints at an issue in the background parser then, which should check whether a document is open currently and prioritize it then. And the currently _focused_ one should be prioritized even further.
    
    Hm, please leave this chunk of code in then but add a big // TODO: ... comment hinting at the above. Someone will then have to fix it properly (if you don't want to do that).


- Milian Wolff


On May 7, 2014, 9:14 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118032/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 9:14 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Reparse the project when includes/defines change
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfg 5d258ed 
>   languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 0e27119 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui ed14ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/118032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140507/099ee2df/attachment.html>