Review Request 118032: Reparse the project when includes/defines change (kdevelop)

[Sergey Kalinichev]

> On May 7, 2014, 1:37 p.m., Milian Wolff wrote:
> > languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp, line 86
> > <https://git.reviewboard.kde.org/r/118032/diff/1/?file=271886#file271886line86>
> >
> >     why is this required?
> >     
> >     when the file was reparsed, its highlighting etc. pp. should be updated automatically. I'd say this block is not needed.

Well, if I remove it, the opened documents will be updated at undefined time in the future. By doing this I'm asking to reparse them now with the highest priority.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118032/#review57481
-----------------------------------------------------------


On May 7, 2014, 1:14 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118032/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 1:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Reparse the project when includes/defines change
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfg 5d258ed 
>   languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 0e27119 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui ed14ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/118032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140507/05327149/attachment.html>