Review Request 117098: Add #include-suggestion to kdev-clang

[Kevin Funk]

> On March 26, 2014, 8:37 p.m., Todd Nowacki wrote:
> > duchain/parsesession.cpp, line 304
> > <https://git.reviewboard.kde.org/r/117098/diff/1/?file=257430#file257430line304>
> >
> >     When will this be invoked?
> >     Do we want to hook this into code completion instead?
> 
> Jørgen Kvalsvik wrote:
>     It's not quite ready for production yet (in hindsight I should've put that in the description).
>     
>     I just realised that it for instance does not port the feature from oldcpp where it can reason on declarations in headers that does match the unknown type name.
>     
>     What I hope to do next is to enable the code completer to scan the list of issues for this particular type and from there decide if it can suggest some header.
>     
>     To answer your question, I don't think it belong solely in code completion. It is a semantic issue in general, not just an auto complete one. However, there is nothing stopping the code completion to tap into the solution provided here and suggest the header include as well. Preferrably through a separate patch.

"I just realised that it for instance does not port the feature from oldcpp where it can reason on declarations in headers that does match the unknown type name." => Yep. That's important, we need that. It's also considerably faster than any other method, I guess.

And I agree to the last paragraph, let's do this "properly" for the problems/solution framework, then we can still hook that into code completion.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117098/#review54231
-----------------------------------------------------------


On March 26, 2014, 7:48 p.m., Jørgen Kvalsvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117098/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 7:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add #include-suggestion features to kdev-clang
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt d21011a 
>   duchain/missinginclude.h PRE-CREATION 
>   duchain/missinginclude.cpp PRE-CREATION 
>   duchain/parsesession.cpp eee9fb1 
> 
> Diff: https://git.reviewboard.kde.org/r/117098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jørgen Kvalsvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140327/7faf0e5f/attachment.html>