<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117098/">https://git.reviewboard.kde.org/r/117098/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 26th, 2014, 8:37 p.m. UTC, <b>Todd Nowacki</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117098/diff/1/?file=257430#file257430line304" style="color: black; font-weight: bold; text-decoration: underline;">duchain/parsesession.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<ProblemPointer> ParseSession::problemsForFile(CXFile file) const</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">239</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QList</span><span class="o"><</span><span class="n">ProblemPointer</span><span class="o">></span> <span class="n">ParseSession</span><span class="o">::</span><span class="n">problemsForFile</span><span class="p">(</span><span class="n">CXFile</span> <span class="n">file</span><span class="p">)</span> <span class="k">const</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">304</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QList</span><span class="o"><</span><span class="n">ProblemPointer</span><span class="o">></span> <span class="n">ParseSession</span><span class="o">::</span><span class="n">problemsForFile</span><span class="p">(</span><span class="n">CXFile</span> <span class="n">file</span><span class="p">)</span> <span class="k">const</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When will this be invoked?
Do we want to hook this into code completion instead?</pre>
</blockquote>
<p>On March 27th, 2014, 8:49 a.m. UTC, <b>Jørgen Kvalsvik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not quite ready for production yet (in hindsight I should've put that in the description).
I just realised that it for instance does not port the feature from oldcpp where it can reason on declarations in headers that does match the unknown type name.
What I hope to do next is to enable the code completer to scan the list of issues for this particular type and from there decide if it can suggest some header.
To answer your question, I don't think it belong solely in code completion. It is a semantic issue in general, not just an auto complete one. However, there is nothing stopping the code completion to tap into the solution provided here and suggest the header include as well. Preferrably through a separate patch.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"I just realised that it for instance does not port the feature from oldcpp where it can reason on declarations in headers that does match the unknown type name." => Yep. That's important, we need that. It's also considerably faster than any other method, I guess.
And I agree to the last paragraph, let's do this "properly" for the problems/solution framework, then we can still hook that into code completion.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On March 26th, 2014, 7:48 p.m. UTC, Jørgen Kvalsvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jørgen Kvalsvik.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 7:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add #include-suggestion features to kdev-clang</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/CMakeLists.txt <span style="color: grey">(d21011a)</span></li>
<li>duchain/missinginclude.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/missinginclude.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(eee9fb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>