Review Request 116897: Allow only 3 arguments to cmake command set_property

[Alexander Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116897/
-----------------------------------------------------------

(Updated March 19, 2014, 5:24 p.m.)


Review request for KDevelop and Aleix Pol Gonzalez.


Changes
-------

Updated patch which adds a test case.


Repository: kdevelop


Description
-------

The llvm cmake build system generates (among others) this line:
set_property(GLOBAL PROPERTY LLVMBUILD_LIB_DEPS_LLVMSupport )
set_property only has 3 arguments which is fine, even cmake documentation for this command says the value is optional.


Diffs (updated)
-----

  projectmanagers/cmake/parser/cmakeast.cpp f39ab0b 
  projectmanagers/cmake/tests/cmakeasttest.cpp 6f4d5a9 

Diff: https://git.reviewboard.kde.org/r/116897/diff/


Testing (updated)
-------

ctest -R cmakeasttest runs without error


Thanks,

Alexander Stein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/e8396af4/attachment.html>