Review Request 116897: Allow only 3 arguments to cmake command set_property

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116897/#review53422
-----------------------------------------------------------


Maybe you can add a test?
In testing you didn't say if the tests still pass.

- Aleix Pol Gonzalez


On March 19, 2014, 12:24 p.m., Alexander Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116897/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:24 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The llvm cmake build system generates (among others) this line:
> set_property(GLOBAL PROPERTY LLVMBUILD_LIB_DEPS_LLVMSupport )
> set_property only has 3 arguments which is fine, even cmake documentation for this command says the value is optional.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.cpp f39ab0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/2085411c/attachment.html>