Review Request 116842: Added virtual override completion to kdev-clang

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116842/#review53404
-----------------------------------------------------------



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37563>

    whitespace after comma :P



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37562>

    ' '



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37564>

    isn't pixmap returning a QPixmap? return that one here without converting it to a QIcon.



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37566>

    this could be a plain QStringList and the assingment below could be replaced by a .clear() and then using it?



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37570>

    bad indentation after this



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37571>

    here and below: please add braces everywhere, even to single-line conditionals



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37569>

    please indent



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37568>

    +1 to what kevin says, or alternatively don't make currentParams a ptr at all and use
    
    OverrideInfo info{functionList, concrete, {}, {}};



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37572>

    brace



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37573>

    braces



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37574>

    yes, that should work I think.



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37576>

    braces


- Milian Wolff


On March 19, 2014, 5:54 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116842/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 5:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added virtual override completion to kdev-clang. Regular functions, template functions, and pure functions work. Signals and slots don't work, and const-qualified functions lose their qualifier. I'm not sure if the UI is completely correct.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.h aa6fcfb 
>   codecompletion/context.cpp f6e85d6 
> 
> Diff: https://git.reviewboard.kde.org/r/116842/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/d72077a0/attachment-0001.html>