Review Request 116842: Added virtual override completion to kdev-clang

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116842/#review53392
-----------------------------------------------------------



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37559>

    Can be reduced to:
    OverrideInfo info{functionList, concrete, {}, nullptr};
    
    (That also makes sure you don't have a dangling pointer for currentParams)
    



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37558>

    I suggest using braces around if-conditions like that (if (...) { ... })


- Kevin Funk


On March 19, 2014, 5:54 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116842/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 5:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added virtual override completion to kdev-clang. Regular functions, template functions, and pure functions work. Signals and slots don't work, and const-qualified functions lose their qualifier. I'm not sure if the UI is completely correct.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.h aa6fcfb 
>   codecompletion/context.cpp f6e85d6 
> 
> Diff: https://git.reviewboard.kde.org/r/116842/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/b2d8d9cd/attachment.html>