Review Request 116772: Fix dvcs test break

[Shubham Chaudhary]

> On March 13, 2014, 8:39 a.m., Aleix Pol Gonzalez wrote:
> > vcs/dvcs/dvcsjob.cpp, line 242
> > <https://git.reviewboard.kde.org/r/116772/diff/2/?file=253611#file253611line242>
> >
> >     Did you remove the emitResult when processing an error?

It was removed in https://git.reviewboard.kde.org/r/116530/#comment36999. I guess we missed it at that time, and turns out it breaks the test. The reason was that when a process exits with some error emitResult is called twice (which is odd), which causes anything connected to result signal getting called twice. 


- Shubham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116772/#review52858
-----------------------------------------------------------


On March 13, 2014, 4:06 a.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116772/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 4:06 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> AFAICS We don't need to call jobIsReady if there is some error, SlotProcessError is supposed do that already. This patch fixes the broken dvcsTest.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.cpp 30a3fcc 
> 
> Diff: https://git.reviewboard.kde.org/r/116772/diff/
> 
> 
> Testing
> -------
> 
> Totals: 3 passed, 0 failed, 0 skipped
> ********* Finished testing of DVcsJobTest *********
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140313/d7222948/attachment.html>