Review Request 116772: Fix dvcs test break

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116772/#review52858
-----------------------------------------------------------


I would say  you should try to minimize the code logic changes.


vcs/dvcs/dvcsjob.cpp
<https://git.reviewboard.kde.org/r/116772/#comment37223>

    Did you remove the emitResult when processing an error?


- Aleix Pol Gonzalez


On March 12, 2014, 10:36 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116772/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 10:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> AFAICS We don't need to call jobIsReady if there is some error, SlotProcessError is supposed do that already. This patch fixes the broken dvcsTest.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.cpp 30a3fcc 
> 
> Diff: https://git.reviewboard.kde.org/r/116772/diff/
> 
> 
> Testing
> -------
> 
> Totals: 3 passed, 0 failed, 0 skipped
> ********* Finished testing of DVcsJobTest *********
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140313/1222b49f/attachment.html>