Review Request 116530: Better handling of VCS error during init and commit

[Shubham Chaudhary]

> On March 10, 2014, 8:08 p.m., Kevin Funk wrote:
> > @Shubham: The dvcsTest seems to be broken now (hangs): http://build.kde.org/job/kdevplatform_stable/376/ -- Can you have a look?
> 
> Shubham Chaudhary wrote:
>     Ah so that's the purpose of that emitResult() in error slot. See I specifically pointed that out before B)
>     Anyway I'll figure out the correct way for it a day after tomorrow. 2 exams per day, can't look into it right now :( Hope you understand.

Just in case it's urgent then let me brief it to you: slotProcessError is meant to emitResult but we're also emitting result in slotProcessExited, so in other cases we were emitting it twice(causing two KMessageBoxes), and now for 'echo -n test' command we aren't even emitting it once, so it hangs.


- Shubham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/#review52550
-----------------------------------------------------------


On March 6, 2014, 11:48 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116530/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 11:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 327931
>     http://bugs.kde.org/show_bug.cgi?id=327931
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch does the following 2 things:
> * Shows detailed failure information through vcsError function when initialization fails.
> * Checks  the status of commit job, if unsuccessful shows a error KMessageBox.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizardplugin.cpp 17d556b 
>   vcs/dvcs/dvcsjob.cpp 6c2275a 
>   vcs/widgets/vcsdiffpatchsources.h 295522f 
>   vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
> 
> Diff: https://git.reviewboard.kde.org/r/116530/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140310/35149f2f/attachment-0001.html>