Review Request 116581: Show warning through FindClang.cmake before failing

[Kevin Funk]

> On March 4, 2014, 10:37 p.m., Commit Hook wrote:
> > This review has been submitted with commit a9c9f0b311b1f2ca090b72921a750f71571a4390 by Kevin Funk to branch master.
> 
> Shubham Chaudhary wrote:
>     This patch will not work because cmake exits after encountering FATAL_ERROR in FindClang.cmake

You are right. I've fixed this now, please have a look at the latest revision.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116581/#review51989
-----------------------------------------------------------


On March 4, 2014, 10:37 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116581/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 10:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> I had clang-3.3 installed but cmake still reported that Clang not found. If clang libraries are not installed just saying "Could NOT find Clang" is not enough. Also show a warning saying "Clang Libraries not found" helps the user install libclang package. Otherwise e.g I had to go through different cmake files one by one to find out that lib package was missing.
> 
> 
> Diffs
> -----
> 
>   cmake/FindClang.cmake d8a8595 
>   CMakeLists.txt 2c4b61a 
> 
> Diff: https://git.reviewboard.kde.org/r/116581/diff/
> 
> 
> Testing
> -------
> 
> Yes, with and without libclang package
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140305/92d4fb46/attachment.html>