Review Request 116581: Show warning through FindClang.cmake before failing
Shubham Chaudhary
shubham.chaudhary at kdemail.net
Tue Mar 4 22:37:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116581/
-----------------------------------------------------------
(Updated March 4, 2014, 10:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop.
Repository: kdev-clang
Description
-------
I had clang-3.3 installed but cmake still reported that Clang not found. If clang libraries are not installed just saying "Could NOT find Clang" is not enough. Also show a warning saying "Clang Libraries not found" helps the user install libclang package. Otherwise e.g I had to go through different cmake files one by one to find out that lib package was missing.
Diffs
-----
cmake/FindClang.cmake d8a8595
CMakeLists.txt 2c4b61a
Diff: https://git.reviewboard.kde.org/r/116581/diff/
Testing
-------
Yes, with and without libclang package
Thanks,
Shubham Chaudhary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140304/05220114/attachment.html>
More information about the KDevelop-devel
mailing list