Review Request 116581: Show warning through FindClang.cmake before failing

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116581/#review51843
-----------------------------------------------------------


Hmm, sorry, on second thought I'm unsure if this is the right way to do it. At least calling display_feature_log from a FindFoo.cmake file sounds weird ...
There's also FindPackageHandleStandardArgs which is usually used to handle the REQUIRED stuff. Why is that not used here ...?

Sorry, Kevin needs to say what to do, I'm at loss ;)

- Sven Brauch


On March 3, 2014, 11:44 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116581/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 11:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> I had clang-3.3 installed but cmake still reported that Clang not found. If clang libraries are not installed just saying "Could NOT find Clang" is not enough. Also show a warning saying "Clang Libraries not found" helps the user install libclang package. Otherwise e.g I had to go through different cmake files one by one to find out that lib package was missing.
> 
> 
> Diffs
> -----
> 
>   cmake/FindClang.cmake d8a8595 
> 
> Diff: https://git.reviewboard.kde.org/r/116581/diff/
> 
> 
> Testing
> -------
> 
> Yes, with and without libclang package
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140303/cbe7234f/attachment.html>