Review Request 116581: Show warning through FindClang.cmake before failing

[Shubham Chaudhary]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116581/
-----------------------------------------------------------

(Updated March 4, 2014, 5:14 a.m.)


Review request for KDevelop.


Changes
-------

Using feature log instead of simple message
Output:
-- Found llvm-config: /usr/bin/llvm-config-3.3

-----------------------------------------------------------------------------
-- The following OPTIONAL packages could NOT be located on your system.
-- Consider installing them to enable more features from this software.
-----------------------------------------------------------------------------
   * libclang (3.3 or higher)  <REQUIRED>
     LibClang is a high level C interface to clang

-----------------------------------------------------------------------------

CMake Error at cmake/FindClang.cmake:73 (message):
  Could NOT find Clang
Call Stack (most recent call first):
  CMakeLists.txt:16 (find_package)


-- Configuring incomplete, errors occurred!


Repository: kdev-clang


Description
-------

I had clang-3.3 installed but cmake still reported that Clang not found. If clang libraries are not installed just saying "Could NOT find Clang" is not enough. Also show a warning saying "Clang Libraries not found" helps the user install libclang package. Otherwise e.g I had to go through different cmake files one by one to find out that lib package was missing.


Diffs (updated)
-----

  cmake/FindClang.cmake d8a8595 

Diff: https://git.reviewboard.kde.org/r/116581/diff/


Testing
-------

Yes, with and without libclang package


Thanks,

Shubham Chaudhary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140303/ad5a738e/attachment.html>