Review Request 116530: Better handling of VCS error during init and commit
Shubham Chaudhary
shubham.chaudhary at kdemail.net
Sun Mar 2 16:42:13 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/
-----------------------------------------------------------
(Updated March 2, 2014, 10:12 p.m.)
Review request for KDevelop.
Bugs: 327931
http://bugs.kde.org/show_bug.cgi?id=327931
Repository: kdevplatform
Description
-------
Patch does the following 2 things:
* Shows detailed failure information through vcsError function when initialization fails.
* Checks the status of commit job, if unsuccessful shows a error KMessageBox.
Diffs (updated)
-----
plugins/appwizard/appwizardplugin.cpp 17d556b
vcs/dvcs/dvcsjob.cpp 6c2275a
vcs/widgets/vcsdiffpatchsources.cpp 77144d9
Diff: https://git.reviewboard.kde.org/r/116530/diff/
Testing
-------
Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
Thanks,
Shubham Chaudhary
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140302/90ada18f/attachment.html>
More information about the KDevelop-devel
mailing list