Review Request 116530: Better handling of VCS error during init and commit

[Kevin Funk]

> On March 2, 2014, 12:14 p.m., Kevin Funk wrote:
> > vcs/widgets/vcsdiffpatchsources.cpp, line 252
> > <https://git.reviewboard.kde.org/r/116530/diff/1/?file=251326#file251326line252>
> >
> >     job might be null here, according to the if-condition
> 
> Shubham Chaudhary wrote:
>     True that, plus errorString doesn't give much useful information. I wanted to show some of the details shown in toolview? I looked at several vcs related classes but still no luck. Any hint?

Hm, that's going to be a bit more work, I guess.

I think DVcsJob should be fixed so it actually calls KJob::setErrorText in case it encounters an error. That way you can then retrieve the error string from the VcsJob instance.

Note that there's currently DVcsJob::errorOutput() which basically duplicates KJob's errorText property afaics. It probably makes sense to get rid off that in a follow-up commit.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/#review51643
-----------------------------------------------------------


On March 2, 2014, 11:17 a.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116530/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 11:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 327931
>     http://bugs.kde.org/show_bug.cgi?id=327931
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch does the following 2 things:
> * Shows detailed failure information through vcsError function when initialization fails.
> * Checks  the status of commit job, if unsuccessful shows a error KMessageBox.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizardplugin.cpp 17d556b 
>   vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
> 
> Diff: https://git.reviewboard.kde.org/r/116530/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140302/b694cad7/attachment-0001.html>