Review Request 118987: Export DBus interface for jumping to a specific line in a file

[Max Schwarz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118987/
-----------------------------------------------------------

(Updated June 30, 2014, 12:58 p.m.)


Review request for KDevelop.


Changes
-------

Took Milian's advice regarding the if block. I also changed the default column to 0, to make it possible to call the method over DBus without a column number.

Everything still works for me.


Repository: kdevplatform


Description
-------

The currently exported DBus interface does not allow opening files & jumping to locations inside the file. This ability is useful for external tools, which could offer to switch to KDevelop with the cursor right at the problematic line of code.

So add optional line and column parameters to the "openDocumentSimple()" method.

In the future the kdevelop executable could be extended to support line number selection from the command line using this DBus call.


Diffs (updated)
-----

  shell/documentcontroller.h 485588a 
  shell/documentcontroller.cpp 1468b16 

Diff: https://git.reviewboard.kde.org/r/118987/diff/


Testing
-------

Tested manually with qdbus and also with a custom log viewer application, which opens KDevelop at the originating line if you click on a log message.


Thanks,

Max Schwarz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140630/da8b536a/attachment.html>