Review Request 118987: Export DBus interface for jumping to a specific line in a file

[Milian Wolff]

> On June 30, 2014, 11:25 a.m., Milian Wolff wrote:
> > shell/documentcontroller.cpp, line 705
> > <https://git.reviewboard.kde.org/r/118987/diff/2/?file=285356#file285356line705>
> >
> >     the implementation of this file could just be
> >     
> >     return openDocument( KUrl(url), KTextEditor::Cursor(line, column) );
> >     
> >     no? Can you try that please? If it works, I'll commit it that way for you then.
> 
> Max Schwarz wrote:
>     I was trying to avoid that because it depends on KTextEditor::Cursor internals (-1 means invalid). If you think that would be better, I can try it this evening.

I wouldn't say its internal, its the convention and imo fine to use here as well.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118987/#review61273
-----------------------------------------------------------


On June 29, 2014, 10 p.m., Max Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118987/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The currently exported DBus interface does not allow opening files & jumping to locations inside the file. This ability is useful for external tools, which could offer to switch to KDevelop with the cursor right at the problematic line of code.
> 
> So add optional line and column parameters to the "openDocumentSimple()" method.
> 
> In the future the kdevelop executable could be extended to support line number selection from the command line using this DBus call.
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.h 485588a 
>   shell/documentcontroller.cpp 1468b16 
> 
> Diff: https://git.reviewboard.kde.org/r/118987/diff/
> 
> 
> Testing
> -------
> 
> Tested manually with qdbus and also with a custom log viewer application, which opens KDevelop at the originating line if you click on a log message.
> 
> 
> Thanks,
> 
> Max Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140630/13689093/attachment-0001.html>