Review Request 118552: Further development of adjust signature assistant

[David Stevens]

> On June 19, 2014, 9:51 a.m., Milian Wolff wrote:
> > util/clangutils.cpp, line 215
> > <https://git.reviewboard.kde.org/r/118552/diff/2/?file=282144#file282144line215>
> >
> >     can you explain what you are trying to achieve here please?

Clang formats pointer types as "t *x" and reference types as "t &x", while it seems to be KDevelop's style to format them as "t* x" and "t& x". This code makes that check. I added a comment to that effect. If you don't think the logic is necessary, I can take it out.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118552/#review60478
-----------------------------------------------------------


On June 18, 2014, 3:29 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118552/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 3:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Improvements which make the assistant behave more consistently.
> 
> However, making it work in as many cases as possible will require work on the core of kdev-clang. This is because it runs into issues where a header file cached in a translation unit is 'stale' (when it has been changed and saved since the translation unit was parsed). This breaks location queries in the cached header file, and I don't think there's any good way to avoid such queries while trying to implement the signature adjustment functionallity. Thoughts?
> 
> 
> Diffs
> -----
> 
>   codegen/clangsignatureassistant.h 7048d2d 
>   codegen/clangsignatureassistant.cpp 07357ff 
>   tests/CMakeLists.txt 7251ce9 
>   tests/test_assistants.h PRE-CREATION 
>   tests/test_assistants.cpp PRE-CREATION 
>   util/clangutils.h cc0565d 
>   util/clangutils.cpp 9553742 
> 
> Diff: https://git.reviewboard.kde.org/r/118552/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests. Each test case passes if run individually, but they don't quite work if run as a group. I believe this is due to issues with the code assistant, so I didn't really bother looking into it because of Kevin's current work in that area.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140620/de860859/attachment.html>