Review Request 118552: Further development of adjust signature assistant

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118552/#review60503
-----------------------------------------------------------



codegen/clangsignatureassistant.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42255>

    Never used?



codegen/clangsignatureassistant.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42254>

    Just use QStringList and use brace-initialization there? Simplifies those two lines.



codegen/clangsignatureassistant.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42253>

    Why? IMO it looks cleaner the other way around.



tests/test_assistants.h
<https://git.reviewboard.kde.org/r/118552/#comment42251>

    Coding style: Uppercase



tests/test_assistants.h
<https://git.reviewboard.kde.org/r/118552/#comment42252>

    Coding style: 4 spaces please



tests/test_assistants.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42250>

    Just use a free function like I did in oldcpp:
    StaticAssistantsManager* staticAssistantsManager() { return Core::self()->languageController()->staticAssistantsManager(); }
    
    And: Don't delete it.



util/clangutils.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42256>

    Make that: (info->fileName.isEmpty() || info->fileName == fileName)
    
    (makes it easier to read)



util/clangutils.cpp
<https://git.reviewboard.kde.org/r/118552/#comment42257>

    As Milian said, please document (and factor out to free function, if possible).


- Kevin Funk


On June 18, 2014, 3:29 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118552/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 3:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Improvements which make the assistant behave more consistently.
> 
> However, making it work in as many cases as possible will require work on the core of kdev-clang. This is because it runs into issues where a header file cached in a translation unit is 'stale' (when it has been changed and saved since the translation unit was parsed). This breaks location queries in the cached header file, and I don't think there's any good way to avoid such queries while trying to implement the signature adjustment functionallity. Thoughts?
> 
> 
> Diffs
> -----
> 
>   codegen/clangsignatureassistant.h 7048d2d 
>   codegen/clangsignatureassistant.cpp 07357ff 
>   tests/CMakeLists.txt 7251ce9 
>   tests/test_assistants.h PRE-CREATION 
>   tests/test_assistants.cpp PRE-CREATION 
>   util/clangutils.h cc0565d 
>   util/clangutils.cpp 9553742 
> 
> Diff: https://git.reviewboard.kde.org/r/118552/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests. Each test case passes if run individually, but they don't quite work if run as a group. I believe this is due to issues with the code assistant, so I didn't really bother looking into it because of Kevin's current work in that area.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140619/fec6b4fd/attachment-0001.html>