Review Request 118818: Detect if 'bzr whoami' informations are available and if not provide default one from KEMailSettings

[Maciej Poleski]

> On June 19, 2014, 12:01 a.m., Milian Wolff wrote:
> > While cool in principle, it fails to do what I had in mind :)
> > 
> > I think this should be done always, whenever a bzr repository is initiated by KDevelop. This is done in the unit test - no? So as soon as that happens, it should directly thereafter check for the whoami information and, if that fails, publish it with the data from KEMailSettings.
> > 
> > Right now, your patch only touches the test code, so if someone would try to initiate a bzr repo without first setting the whoami globally, it would fail - no?

The problem is with informations from KEMailSettings. These are always wrong (at least for me - it consists of correct name and empty email address - default "local" identity). If these informations were used to initialize 'bzr whoami' and then to make commit, we would get broken repository history. As a result we would have to manually fix whoami informations and then rewrite history (which in general is not the best idea).
In fact considering all informations contained in various KDE PIM applications what is clear is that it is impossible to implicitly pick the correct one (machine would have to read my mind). It still may be done explicitly (by asking user to pick appropriate identity from set of configured KDE PIM identities) but I don't see clear way to achieve this.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118818/#review60453
-----------------------------------------------------------


On June 18, 2014, 10:59 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118818/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 10:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Detect if 'bzr whoami' informations are available during testing. If not use KEMailSettings to get defaults and set them on per-branch basis.
> 
> 
> Diffs
> -----
> 
>   plugins/bazaar/tests/bazaartest.cpp 86ff36f 
>   plugins/bazaar/tests/bazaartest.h 29248aa 
> 
> Diff: https://git.reviewboard.kde.org/r/118818/diff/
> 
> 
> Testing
> -------
> 
> Tested on environment with and without 'bzr whoami' informations.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140618/b2d5fbd8/attachment.html>