Review Request 118818: Detect if 'bzr whoami' informations are available and if not provide default one from KEMailSettings

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118818/#review60453
-----------------------------------------------------------


While cool in principle, it fails to do what I had in mind :)

I think this should be done always, whenever a bzr repository is initiated by KDevelop. This is done in the unit test - no? So as soon as that happens, it should directly thereafter check for the whoami information and, if that fails, publish it with the data from KEMailSettings.

Right now, your patch only touches the test code, so if someone would try to initiate a bzr repo without first setting the whoami globally, it would fail - no?

- Milian Wolff


On June 18, 2014, 8:59 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118818/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 8:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Detect if 'bzr whoami' informations are available during testing. If not use KEMailSettings to get defaults and set them on per-branch basis.
> 
> 
> Diffs
> -----
> 
>   plugins/bazaar/tests/bazaartest.cpp 86ff36f 
>   plugins/bazaar/tests/bazaartest.h 29248aa 
> 
> Diff: https://git.reviewboard.kde.org/r/118818/diff/
> 
> 
> Testing
> -------
> 
> Tested on environment with and without 'bzr whoami' informations.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140618/dd173c57/attachment-0001.html>