Review Request 118543: Adapt to new kdevplatform API regarding assistants

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118543/#review59335
-----------------------------------------------------------

Ship it!


looks good, some small issues only


languages/cpp/codegen/signatureassistant.h
<https://git.reviewboard.kde.org/r/118543/#comment41303>

    put brace on newline (yes, was wrong before)



languages/cpp/tests/test_cppassistants.cpp
<https://git.reviewboard.kde.org/r/118543/#comment41302>

    rename to s_assistantsManager
    
    or just make it a function which forwards Core::self()->... ?



languages/cpp/tests/test_cppassistants.cpp
<https://git.reviewboard.kde.org/r/118543/#comment41301>

    why, its in the language controller, no?



languages/cpp/tests/test_cppassistants.cpp
<https://git.reviewboard.kde.org/r/118543/#comment41300>

    ? whats this? should this be removed or must that be fixed, i.e. added again?


- Milian Wolff


On June 4, 2014, 8:59 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118543/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 8:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Adapt to new kdevplatform API regarding assistants
> 
> Fixup the existing AdaptDefinitionSignatureAssistant, fixup
> initialization in CppLanguageSupport.
> 
> Add a few more tests for assistants
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt d556e86e3fe1d8c402e43890ce85e4f1d1558469 
>   languages/cpp/codegen/adaptsignatureaction.h 6b6a6254e68cb69b03c4d5dcfa3aea03dafad29f 
>   languages/cpp/codegen/adaptsignatureaction.cpp 27f1c9eb75b810879b40b2f1344c63d89027ec59 
>   languages/cpp/codegen/codeassistant.h 3ad703617a8af9b2109ca079b5d97bfbb54bce46 
>   languages/cpp/codegen/codeassistant.cpp a467dc39bce5b46162e1d736cbb9461ffc325ab0 
>   languages/cpp/codegen/renameaction.h 7ae44a66f23823ffaea6a2544ed25d42b99a477b 
>   languages/cpp/codegen/renameaction.cpp 291e5a71059c08de9c73b22f97799d9f910fbbbf 
>   languages/cpp/codegen/renameassistant.h 93f701b84de2e966bd4968a67816ac15cc41fc50 
>   languages/cpp/codegen/renameassistant.cpp a1012f3e75218911ffc31d6f858a645b5ce28d07 
>   languages/cpp/codegen/renamefileaction.h 32d7a2ac07785a45e90ad26206026c9b964cd73f 
>   languages/cpp/codegen/renamefileaction.cpp 4ac7921e72ad2be4234d0d65cc99a8ff12d26427 
>   languages/cpp/codegen/signatureassistant.h e440d07a9fbe6068f0bb3a59bdefcd37300a460e 
>   languages/cpp/codegen/signatureassistant.cpp 6073837fd0c0cb97aae07c6a9097fa8658aa2985 
>   languages/cpp/codegen/simplerefactoring.h 3237ffc5b727d11792b687275aae21ecf898299e 
>   languages/cpp/codegen/simplerefactoring.cpp 3e4fe74a84ece62576b65f32a92df4d84e749e8a 
>   languages/cpp/cpplanguagesupport.h 135eb413afa4c331d9bdd101f5c1ee21532cb357 
>   languages/cpp/cpplanguagesupport.cpp 9ef0c9bf7481259e69c10ea85bcec6bc4bd6277d 
>   languages/cpp/tests/CMakeLists.txt 994c6ec30c1651cfb45254f489d43d2a5bfcd86d 
>   languages/cpp/tests/test_cppassistants.h ef05daf4ac4dfffc95d7a35117ec1008a966a4ba 
>   languages/cpp/tests/test_cppassistants.cpp d106549f1a6bc025a2f1680308d2dfb7abebe4ef 
> 
> Diff: https://git.reviewboard.kde.org/r/118543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140605/30fb6baa/attachment.html>