<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118543/">https://git.reviewboard.kde.org/r/118543/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, some small issues only</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118543/diff/1/?file=278929#file278929line40" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/codegen/signatureassistant.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KDevelop {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">AdaptDefinitionSignatureAssistant</span> <span class="o">:</span> <span class="n">public</span> <span class="n"><span class="hl">I</span>Assistant</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">AdaptDefinitionSignatureAssistant</span> <span class="o">:</span> <span class="n">public</span> <span class="n"><span class="hl">Static</span>Assistant</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">put brace on newline (yes, was wrong before)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118543/diff/1/?file=278937#file278937line55" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/tests/test_cppassistants.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Cpp::StaticCodeAssistant *staticCodeAssistant = 0;</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">StaticAssistantsManager *staticAssistantsManager = 0;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n"><span class="hl">Cpp</span></span><span class="o"><span class="hl">::</span></span><span class="n">Static<span class="hl">Code</span>Assistant</span> <span class="o">*</span><span class="n">static<span class="hl">Code</span>Assistant</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">StaticAssistant<span class="hl">sManager</span></span> <span class="o">*</span><span class="n">staticAssistant<span class="hl">sManager</span></span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rename to s_assistantsManager
or just make it a function which forwards Core::self()->... ?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118543/diff/1/?file=278937#file278937line72" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/tests/test_cppassistants.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Cpp::StaticCodeAssistant *staticCodeAssistant = 0;</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">StaticAssistantsManager *staticAssistantsManager = 0;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">static<span class="hl">Code</span>Assistant</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">staticAssistant<span class="hl">sManager</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why, its in the language controller, no?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118543/diff/1/?file=278937#file278937line369" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/tests/test_cppassistants.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TestCppAssistants::testSignatureAssistant_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">364</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVERIFY</span><span class="p">(</span><span class="o">!</span><span class="n">staticAssistantsManager</span><span class="o">-></span><span class="n">activeAssistant</span><span class="p">());</span><span class="c1">// || !staticCodeAssistant->activeAssistant()->actions().size());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">? whats this? should this be removed or must that be fixed, i.e. added again?</pre>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On June 4th, 2014, 8:59 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 8:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adapt to new kdevplatform API regarding assistants
Fixup the existing AdaptDefinitionSignatureAssistant, fixup
initialization in CppLanguageSupport.
Add a few more tests for assistants</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(d556e86e3fe1d8c402e43890ce85e4f1d1558469)</span></li>
<li>languages/cpp/codegen/adaptsignatureaction.h <span style="color: grey">(6b6a6254e68cb69b03c4d5dcfa3aea03dafad29f)</span></li>
<li>languages/cpp/codegen/adaptsignatureaction.cpp <span style="color: grey">(27f1c9eb75b810879b40b2f1344c63d89027ec59)</span></li>
<li>languages/cpp/codegen/codeassistant.h <span style="color: grey">(3ad703617a8af9b2109ca079b5d97bfbb54bce46)</span></li>
<li>languages/cpp/codegen/codeassistant.cpp <span style="color: grey">(a467dc39bce5b46162e1d736cbb9461ffc325ab0)</span></li>
<li>languages/cpp/codegen/renameaction.h <span style="color: grey">(7ae44a66f23823ffaea6a2544ed25d42b99a477b)</span></li>
<li>languages/cpp/codegen/renameaction.cpp <span style="color: grey">(291e5a71059c08de9c73b22f97799d9f910fbbbf)</span></li>
<li>languages/cpp/codegen/renameassistant.h <span style="color: grey">(93f701b84de2e966bd4968a67816ac15cc41fc50)</span></li>
<li>languages/cpp/codegen/renameassistant.cpp <span style="color: grey">(a1012f3e75218911ffc31d6f858a645b5ce28d07)</span></li>
<li>languages/cpp/codegen/renamefileaction.h <span style="color: grey">(32d7a2ac07785a45e90ad26206026c9b964cd73f)</span></li>
<li>languages/cpp/codegen/renamefileaction.cpp <span style="color: grey">(4ac7921e72ad2be4234d0d65cc99a8ff12d26427)</span></li>
<li>languages/cpp/codegen/signatureassistant.h <span style="color: grey">(e440d07a9fbe6068f0bb3a59bdefcd37300a460e)</span></li>
<li>languages/cpp/codegen/signatureassistant.cpp <span style="color: grey">(6073837fd0c0cb97aae07c6a9097fa8658aa2985)</span></li>
<li>languages/cpp/codegen/simplerefactoring.h <span style="color: grey">(3237ffc5b727d11792b687275aae21ecf898299e)</span></li>
<li>languages/cpp/codegen/simplerefactoring.cpp <span style="color: grey">(3e4fe74a84ece62576b65f32a92df4d84e749e8a)</span></li>
<li>languages/cpp/cpplanguagesupport.h <span style="color: grey">(135eb413afa4c331d9bdd101f5c1ee21532cb357)</span></li>
<li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(9ef0c9bf7481259e69c10ea85bcec6bc4bd6277d)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(994c6ec30c1651cfb45254f489d43d2a5bfcd86d)</span></li>
<li>languages/cpp/tests/test_cppassistants.h <span style="color: grey">(ef05daf4ac4dfffc95d7a35117ec1008a966a4ba)</span></li>
<li>languages/cpp/tests/test_cppassistants.cpp <span style="color: grey">(d106549f1a6bc025a2f1680308d2dfb7abebe4ef)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118543/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>