Review Request 118552: Further development of adjust signature assistant

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118552/#review59271
-----------------------------------------------------------


Hey, unfortunately we're touching the same code right now. I've just moved CodeAssistant to kdevplatform (see https://git.reviewboard.kde.org/r/118542/).

I think it makes sense to wait for my patch to get merged before merging this one here. After that, you should be able to more or less copy&paste test_cppassistant.cpp from oldcpp.

At any rate, thanks for working on this and providing tests! Should be relatively easy to rebase this patch here on my changes after they got merged.

- Kevin Funk


On June 5, 2014, 7:18 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118552/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 7:18 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Improvements which make the assistant behave more consistently.
> 
> However, making it work in as many cases as possible will require work on the core of kdev-clang. This is because it runs into issues where a header file cached in a translation unit is 'stale' (when it has been changed and saved since the translation unit was parsed). This breaks location queries in the cached header file, and I don't think there's any good way to avoid such queries while trying to implement the signature adjustment functionallity. Thoughts?
> 
> 
> Diffs
> -----
> 
>   codegen/clangsignatureassistant.h 16afa5f 
>   codegen/clangsignatureassistant.cpp 489becf 
>   codegen/codeassistant.h d1807ed 
>   codegen/codeassistant.cpp ea55b79 
>   tests/CMakeLists.txt 7951bce 
>   tests/test_assistants.h PRE-CREATION 
>   tests/test_assistants.cpp PRE-CREATION 
>   util/clangutils.h cc0565d 
>   util/clangutils.cpp 9553742 
> 
> Diff: https://git.reviewboard.kde.org/r/118552/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests. Each test case passes if run individually, but they don't quite work if run as a group. I believe this is due to issues with the code assistant, so I didn't really bother looking into it because of Kevin's current work in that area.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140605/60f1f96f/attachment.html>