Review Request 118552: Further development of adjust signature assistant

David Stevens dgedstevens at
Thu Jun 5 07:18:49 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.

Repository: kdev-clang


Improvements which make the assistant behave more consistently.

However, making it work in as many cases as possible will require work on the core of kdev-clang. This is because it runs into issues where a header file cached in a translation unit is 'stale' (when it has been changed and saved since the translation unit was parsed). This breaks location queries in the cached header file, and I don't think there's any good way to avoid such queries while trying to implement the signature adjustment functionallity. Thoughts?


  codegen/clangsignatureassistant.h 16afa5f 
  codegen/clangsignatureassistant.cpp 489becf 
  codegen/codeassistant.h d1807ed 
  codegen/codeassistant.cpp ea55b79 
  tests/CMakeLists.txt 7951bce 
  tests/test_assistants.h PRE-CREATION 
  tests/test_assistants.cpp PRE-CREATION 
  util/clangutils.h cc0565d 
  util/clangutils.cpp 9553742 



Added unit tests. Each test case passes if run individually, but they don't quite work if run as a group. I believe this is due to issues with the code assistant, so I didn't really bother looking into it because of Kevin's current work in that area.


David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list