Review Request 115374: Port the BasicRefactoring::startInteractiveRename code to a .ui

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115374/#review48517
-----------------------------------------------------------


Looks good! Please wait for somebody else to approve, though.
As for validation: Since the language plugins take care of instantiating this class anyways, I think there should be a virtual function which decides whether something is a valid name or not, and the default implementation should consider only purely alphanumberic strings valid. That should fit most languages, and if some language has special needs (e.g. JS) it can easily override it.

Greetings!

- Sven Brauch


On Jan. 29, 2014, 9:07 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115374/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 9:07 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 330263
>     http://bugs.kde.org/show_bug.cgi?id=330263
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> There is one open question though: Should there be foolproof checks or not? (e.g. new name doesn't contain spaces, dots, braces e.t.c).
> I think there should be input validation, still maybe that check isn't implemented intentionally so that all other languages, that consider those symbols valid for function/variable names, can use refactoring capabilities too?
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 11a26da 
>   language/codegen/basicrefactoring.cpp 3c584d2 
>   language/codegen/basicrefactoring.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115374/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140129/2ff096a5/attachment.html>