Review Request 115374: Port the BasicRefactoring::startInteractiveRename code to a .ui
Sergey Kalinichev
kalinichev.so.0 at gmail.com
Wed Jan 29 09:07:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115374/
-----------------------------------------------------------
Review request for KDevelop.
Bugs: 330263
http://bugs.kde.org/show_bug.cgi?id=330263
Repository: kdevplatform
Description
-------
There is one open question though: Should there be foolproof checks or not? (e.g. new name doesn't contain spaces, dots, braces e.t.c).
I think there should be input validation, still maybe that check isn't implemented intentionally so that all other languages, that consider those symbols valid for function/variable names, can use refactoring capabilities too?
Diffs
-----
language/CMakeLists.txt 11a26da
language/codegen/basicrefactoring.cpp 3c584d2
language/codegen/basicrefactoring.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115374/diff/
Testing
-------
Thanks,
Sergey Kalinichev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140129/4969d9f9/attachment.html>
More information about the KDevelop-devel
mailing list