Review Request 115226: quickopen abbreviation matching

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115226/#review48202
-----------------------------------------------------------


code looks good - but I'm still missing some benchmark numbers :) these should also go into the commit message then - like a simple before/after of the existing benchmark suite would be OK as a first approximation


language/interfaces/abbreviations.h
<https://git.reviewboard.kde.org/r/115226/#comment34100>

    still all inline, please put these into a .cpp file



language/interfaces/quickopenfilter.h
<https://git.reviewboard.kde.org/r/115226/#comment34101>

    .join(QString())


- Milian Wolff


On Jan. 23, 2014, 2:08 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115226/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 2:08 a.m.)
> 
> 
> Review request for KDevelop and Vishesh Handa.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Adds abbreviation matching for quickopen, similar to what the completion does now.
> 
> For duchain items, you can do component-wise abbrev matching with the same algorithm like in kate.
> For example, py::pyccwor matches "Python::PythonCodeCompletionWorker", kdev::cccont matches "KDevelop::CodeCompletionContext", etc.
> 
> For project items, you can type any set of characters from the path of the item. So, btbrowser/cml matches addons/kate/backtracebrowser/CMakeLists.txt. The idea is that often you can abbreviate path names but they seldomly contain capital letters, so it doesn't make much sense to restrict it to capital letters.
> 
> I'm not sure this is the perfect way to do it, feedback is welcome.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt d5f29c1 
>   language/interfaces/abbreviations.h PRE-CREATION 
>   language/interfaces/quickopenfilter.h cd3afa9 
>   plugins/quickopen/projectitemquickopen.cpp 8be9dd8 
>   plugins/quickopen/tests/quickopentest.h eff5b93 
>   plugins/quickopen/tests/quickopentest.cpp 3827237 
>   plugins/quickopen/tests/quickopentestbase.h 1205379 
> 
> Diff: https://git.reviewboard.kde.org/r/115226/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140124/b77daaf6/attachment.html>