<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115226/">https://git.reviewboard.kde.org/r/115226/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">code looks good - but I'm still missing some benchmark numbers :) these should also go into the commit message then - like a simple before/after of the existing benchmark suite would be OK as a first approximation</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115226/diff/5/?file=235410#file235410line29" style="color: black; font-weight: bold; text-decoration: underline;">language/interfaces/abbreviations.h</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="kt">bool</span> <span class="nf">matchesAbbreviationHelper</span><span class="p">(</span><span class="k">const</span> <span class="n">QStringRef</span><span class="o">&</span> <span class="n">word</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">typed</span><span class="p">,</span> <span class="k">const</span> <span class="n">QVarLengthArray</span><span class="o"><</span><span class="kt">int</span><span class="p">,</span> <span class="mi">32</span><span class="o">>&</span> <span class="n">offsets</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">still all inline, please put these into a .cpp file</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115226/diff/5/?file=235411#file235411line179" style="color: black; font-weight: bold; text-decoration: underline;">language/interfaces/quickopenfilter.h</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">joinedText</span> <span class="o">=</span> <span class="n">text</span><span class="p">.</span><span class="n">join</span><span class="p">(</span><span class="s">""</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">.join(QString())</pre>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 23rd, 2014, 2:08 a.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Vishesh Handa.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2014, 2:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds abbreviation matching for quickopen, similar to what the completion does now.
For duchain items, you can do component-wise abbrev matching with the same algorithm like in kate.
For example, py::pyccwor matches "Python::PythonCodeCompletionWorker", kdev::cccont matches "KDevelop::CodeCompletionContext", etc.
For project items, you can type any set of characters from the path of the item. So, btbrowser/cml matches addons/kate/backtracebrowser/CMakeLists.txt. The idea is that often you can abbreviate path names but they seldomly contain capital letters, so it doesn't make much sense to restrict it to capital letters.
I'm not sure this is the perfect way to do it, feedback is welcome.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/CMakeLists.txt <span style="color: grey">(d5f29c1)</span></li>
<li>language/interfaces/abbreviations.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/interfaces/quickopenfilter.h <span style="color: grey">(cd3afa9)</span></li>
<li>plugins/quickopen/projectitemquickopen.cpp <span style="color: grey">(8be9dd8)</span></li>
<li>plugins/quickopen/tests/quickopentest.h <span style="color: grey">(eff5b93)</span></li>
<li>plugins/quickopen/tests/quickopentest.cpp <span style="color: grey">(3827237)</span></li>
<li>plugins/quickopen/tests/quickopentestbase.h <span style="color: grey">(1205379)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115226/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>