Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Mikhail Krutov]

> On Jan. 22, 2014, 9:58 p.m., Aleix Pol Gonzalez wrote:
> > plugins/git/gitplugin.cpp, line 195
> > <https://git.reviewboard.kde.org/r/115232/diff/2/?file=235360#file235360line195>
> >
> >     You're leaking the process

QProcess is not used anymore, thus issue is dropped.


- Mikhail


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/#review48083
-----------------------------------------------------------


On Jan. 23, 2014, 10:26 p.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115232/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 10:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=327931
> When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp a582b0a 
> 
> Diff: https://git.reviewboard.kde.org/r/115232/diff/
> 
> 
> Testing
> -------
> 
> Install kdevgit.so plugin, then run KDevelop with empty ~/.gitconfig & with valid ~/.gitconfig
> This patch has an issue that KDialog is not an active window on KDevelop start (e.g. KDevelop takes WM focus).
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140123/ae066dbe/attachment.html>