Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Mikhail Krutov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/
-----------------------------------------------------------

(Updated Jan. 23, 2014, 10:26 p.m.)


Review request for KDevelop.


Changes
-------

This is not what I originally meant to implement, however it solves the problem with commit & failing git
With previous code, patchreview window did not raise the VcsView toolview (e.g. if user had other toolview in focus before trying to commit something). 
This raises it up when closing, showing any errors or successes that occured. 


Repository: kdevplatform


Description
-------

https://bugs.kde.org/show_bug.cgi?id=327931
When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.


Diffs (updated)
-----

  plugins/patchreview/patchreview.cpp a582b0a 

Diff: https://git.reviewboard.kde.org/r/115232/diff/


Testing
-------

Install kdevgit.so plugin, then run KDevelop with empty ~/.gitconfig & with valid ~/.gitconfig
This patch has an issue that KDialog is not an active window on KDevelop start (e.g. KDevelop takes WM focus).


Thanks,

Mikhail Krutov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140123/7d95d607/attachment.html>