Review Request 115117: Handle global variables in namespaces correctly

[Heinz Wiesinger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115117/
-----------------------------------------------------------

(Updated Jan. 20, 2014, 2:49 p.m.)


Review request for KDevelop.


Changes
-------

Split out duplicated code into a separate function and better locking


Bugs: 255537
    http://bugs.kde.org/show_bug.cgi?id=255537


Repository: kdev-php


Description
-------

Handle global variables in namespaces correctly.

PHP does not support namespaced variables. Variable declarations
inside a namespace are just global declarations.


Diffs (updated)
-----

  duchain/tests/uses.h 16b7303df21616726814095337c6cc0a779de951 
  duchain/tests/uses.cpp eac94603e7d86c5c9b8efdb804372a729e3e8cd1 
  duchain/builders/declarationbuilder.cpp 24d68558f3ea8528ca7e66338bb8e8405849aecb 
  duchain/expressionvisitor.h 97bfb8ea4b8cb56b8011fe8974a682aee22bc16c 
  duchain/expressionvisitor.cpp 6374a63b7fa41b9a0a14aeb69e571211eab8ac63 

Diff: https://git.reviewboard.kde.org/r/115117/diff/


Testing
-------

Unit tests and parsing various test files


Thanks,

Heinz Wiesinger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140120/0286c8d0/attachment.html>