Review Request 115117: Handle global variables in namespaces correctly

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115117/#review47773
-----------------------------------------------------------



duchain/expressionvisitor.cpp
<https://git.reviewboard.kde.org/r/115117/#comment33871>

    context->type must be accessed while holding the lock



duchain/expressionvisitor.cpp
<https://git.reviewboard.kde.org/r/115117/#comment33872>

    just DUChainReadLocker lock; is enough



duchain/expressionvisitor.cpp
<https://git.reviewboard.kde.org/r/115117/#comment33873>

    push into function, share code with above


- Milian Wolff


On Jan. 19, 2014, 11 a.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115117/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 11 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 255537
>     http://bugs.kde.org/show_bug.cgi?id=255537
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> Handle global variables in namespaces correctly.
> 
> PHP does not support namespaced variables. Variable declarations
> inside a namespace are just global declarations.
> 
> 
> Diffs
> -----
> 
>   duchain/builders/declarationbuilder.cpp 24d68558f3ea8528ca7e66338bb8e8405849aecb 
>   duchain/expressionvisitor.cpp 6374a63b7fa41b9a0a14aeb69e571211eab8ac63 
>   duchain/tests/uses.h 16b7303df21616726814095337c6cc0a779de951 
>   duchain/tests/uses.cpp eac94603e7d86c5c9b8efdb804372a729e3e8cd1 
> 
> Diff: https://git.reviewboard.kde.org/r/115117/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and parsing various test files
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140120/9ed3948e/attachment.html>