Review Request 114582: Allow external scripts to execute on folders if using %d parameter

Commit Hook null at kde.org
Thu Jan 16 07:43:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114582/#review47484
-----------------------------------------------------------


This review has been submitted with commit 344fa7cf4c7ce1d91cabe38d7045b91a564930eb by Niko Sams to branch master.

- Commit Hook


On Dec. 21, 2013, 11:36 a.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114582/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 11:36 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Currently external scripts can only be run on files.
> 
> This patch allows calling them from project view context menu on folders under the following condition:
> - %d parameter is used
> - file related parameters (%s, %u, %f, %b or %n) are not used
> 
> When calling the script in any other way nothing changes - the directory of the current file will be passed as %d parameter.
> 
> 
> Diffs
> -----
> 
>   plugins/externalscript/externalscriptjob.h 69ae48b 
>   plugins/externalscript/externalscriptjob.cpp decb006 
>   plugins/externalscript/externalscriptplugin.h 4016fb2 
>   plugins/externalscript/externalscriptplugin.cpp 57a0e1f 
> 
> Diff: https://git.reviewboard.kde.org/r/114582/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140116/cad9fa4e/attachment.html>


More information about the KDevelop-devel mailing list