<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114582/">https://git.reviewboard.kde.org/r/114582/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 344fa7cf4c7ce1d91cabe38d7045b91a564930eb by Niko Sams to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 21st, 2013, 11:36 a.m. UTC, Niko Sams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Niko Sams.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2013, 11:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently external scripts can only be run on files.
This patch allows calling them from project view context menu on folders under the following condition:
- %d parameter is used
- file related parameters (%s, %u, %f, %b or %n) are not used
When calling the script in any other way nothing changes - the directory of the current file will be passed as %d parameter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/externalscript/externalscriptjob.h <span style="color: grey">(69ae48b)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(decb006)</span></li>
<li>plugins/externalscript/externalscriptplugin.h <span style="color: grey">(4016fb2)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(57a0e1f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114582/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>