Review Request 114874: Qt5: Initial port to KF5-based build system

Kevin Funk krf at gmx.de
Sun Jan 5 15:42:14 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114874/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 3:42 p.m.)


Review request for KDevelop and Aleix Pol Gonzalez.


Changes
-------

Removed the "Qt5: Drop QtGui/ prefix from includes" commit. This is a no-brainer anyway and just clutters the review.


Repository: kdevplatform


Description (updated)
-------

Qt5: Initial port to KF5-based build system

Port away from CMake code provided by kdelibs and use macros from the
ECM package.

Not in a compilable state atm. Just touched the build system.


Diffs (updated)
-----

  CMakeLists.txt 9b10bbad4eb17d636210749b3952970e2eb4857e 
  debugger/CMakeLists.txt bec440d140b318b13bf6b596d6a5beedf5062ae6 
  documentation/CMakeLists.txt 83c55c4d9e6661843dd059d79ceced9f27aaafc4 
  interfaces/CMakeLists.txt 5bb02b229a91b618d6bf5441ff76379e53d8ab0d 
  interfaces/tests/CMakeLists.txt 32124fa6417f81484e12f701175334961390d786 
  language/CMakeLists.txt 72ab78e368907f274fcd93a9e2acf862ab29b67f 
  language/backgroundparser/tests/CMakeLists.txt f07758e2131a6c672369aecec4173fac6aa08554 
  language/codegen/tests/CMakeLists.txt a168f9c9629709d8182f8019e3d55745d15f8560 
  language/duchain/tests/CMakeLists.txt 20cc76b74f13229341458060403383c5809b58a1 
  language/duchain/tests/serialization/CMakeLists.txt f82ffbdaf9c7a73c213fd82fd33bc4fb9d9e6649 
  language/highlighting/tests/CMakeLists.txt 559144c192fa2a6084304ef28034fa98372d7565 
  outputview/CMakeLists.txt b15d640f4486e863dd90caa8560f9c332cc66810 
  outputview/tests/CMakeLists.txt 321e8a3a2a3c88648af38b22e9d2de2d4803b49e 
  plugins/CMakeLists.txt e0ccbc123e8113ea3a552c06db2a7833b07782cc 
  plugins/appwizard/CMakeLists.txt d2714ca715d9e6fa577b0dcbd7831cc52dbc4fa3 
  plugins/classbrowser/CMakeLists.txt 25542c09d8693db9897d50756b6e706099bc86b3 
  plugins/codeutils/CMakeLists.txt c5a06c4ea15a423e592ef5793621eab7ea2dd9ba 
  plugins/codeutils/tests/CMakeLists.txt da38e25fd1be8429f31590383db77eabcc71e948 
  plugins/contextbrowser/CMakeLists.txt 8bd52cc6332d1cbec1aecf36ae6df75492d9d81f 
  plugins/cvs/CMakeLists.txt dbc3af7f39b125ba35f971f8314da44beff98fb1 
  plugins/cvs/tests/CMakeLists.txt 1ef17464d313d2a9219ef91cd87bd7f3032acf5b 
  plugins/dashboard/CMakeLists.txt f3b606d17fd46e80b755e321b9dde42be1b6a298 
  plugins/dashboard/declarative/CMakeLists.txt 0d5cfa40734ef134fcbebdb383cf26891c5c3a26 
  plugins/dashboard/plasmoids/projectfileplasmoid/CMakeLists.txt d3016d73b581e4a2e470325853c42f5b47b50f38 
  plugins/documentswitcher/CMakeLists.txt 37574d04c29459bfce3935cd5ef7ee7b35c14d44 
  plugins/documentview/CMakeLists.txt 57daa63a6d8d1b242b853cc599f88ff7bd2583db 
  plugins/documentview/settings/CMakeLists.txt f62c7ce6fd688a4a1c0c1af9f9f43ddf096d73e9 
  plugins/execute/CMakeLists.txt 5313b7b88ed879aad6ee57c01b63c477da578f66 
  plugins/executescript/CMakeLists.txt bcd7d41289af6525f57c4e8743f519bf617c6ac2 
  plugins/externalscript/CMakeLists.txt 90afcfa7142e4ac2f2af31117b86443d450ce6af 
  plugins/filemanager/CMakeLists.txt 08d90741c540ccd74a70786b9cd0c15e8759198d 
  plugins/filetemplates/CMakeLists.txt f9a16ecc480ff52589e15ee9fbbd3131f833fea7 
  plugins/genericprojectmanager/CMakeLists.txt 7a7cce9e8165926f43a0def71df93f03dc41b5f4 
  plugins/genericprojectmanager/test/CMakeLists.txt 3cb7d726ec2904efba3287e0e1338db58982139f 
  plugins/git/CMakeLists.txt 05a261ba9e59a76d7def4c1cf2b3346692d9ba37 
  plugins/git/icons/CMakeLists.txt dc4e8983269eba856556e14a8a5954c080400060 
  plugins/git/tests/CMakeLists.txt b55df9d21f3ff2f55f9305db6474b57d60badb98 
  plugins/grepview/CMakeLists.txt 0a6308336ae275f4e9069112109aae4efae89fa9 
  plugins/grepview/tests/CMakeLists.txt 02b907899bb65d72fd0e4fd76fd6399aeafdb2c4 
  plugins/konsole/CMakeLists.txt 5f5ea53975fd1287986c5d3d8b7a9d85c10e5e5c 
  plugins/openwith/CMakeLists.txt 6c43a957232909806203042b045e488acb4c94fc 
  plugins/pastebin/CMakeLists.txt efeef1f0d3d814db3b861e7d34c647f12689acfc 
  plugins/patchreview/CMakeLists.txt ba150dcf8f672d6dc4a788acc720b639dfeb78d2 
  plugins/patchreview/libdiff2/tests/CMakeLists.txt 61ea7ef83dd244031cad41d3f1ed0a6119f373f4 
  plugins/problemreporter/CMakeLists.txt ad1162e2e48f6a5ffdfafca7f434c8ec890d0817 
  plugins/projectfilter/CMakeLists.txt 8e5d0b956d085f77d0ed4db4f851dbe1b68bd81a 
  plugins/projectfilter/tests/CMakeLists.txt bca35add561883269bd430e4cf5ef573c3ebfd19 
  plugins/projectmanagerview/CMakeLists.txt 1fc4ad9c5679319b7873817d0ea744767e1a5ac4 
  plugins/quickopen/CMakeLists.txt 19ce904073bb5a5bee7048bce82cbe6b82c38101 
  plugins/quickopen/tests/CMakeLists.txt e967c79d2af886c423eeb8773171074756b89478 
  plugins/reviewboard/CMakeLists.txt a6a2aeae99be8f468d7983c673de2f836b2e519e 
  plugins/reviewboard/icons/CMakeLists.txt 1cc07729d578a5524f873522338a46bb994a0f61 
  plugins/reviewboard/tests/CMakeLists.txt f5fcc2a3e3d55474a174fd2dbb74105f92a6b144 
  plugins/snippet/CMakeLists.txt e90d0ea6252b50e9638115f666d93d3f257f10a4 
  plugins/standardoutputview/CMakeLists.txt 88c0478f183b26f298d37be506dbe0f8d538a334 
  plugins/standardoutputview/tests/CMakeLists.txt 6267f4855310983a7c6de37f5a723d8a08feae38 
  plugins/subversion/CMakeLists.txt 70359fa4cf8a2235d93af7e9471bcae56fcc2500 
  plugins/subversion/icons/CMakeLists.txt dc4e8983269eba856556e14a8a5954c080400060 
  plugins/subversion/tests/CMakeLists.txt 4744f9f516c6c4cd8fa061099c670747a0e1b9de 
  plugins/switchtobuddy/CMakeLists.txt 32898d48ec7f453b42a5d65f97d3d1e4ba97b97b 
  plugins/templatemanager/CMakeLists.txt cc3ea92ec64d7fee1c355503ea6ff55dea6d400e 
  plugins/testview/CMakeLists.txt 9d6678a0788db04759a4bd8866ae289ad5135469 
  plugins/vcschangesview/CMakeLists.txt 0bc082a801b533a0b0f8d21ce5e46990f56d27b8 
  project/CMakeLists.txt 2e3ce8c1ddb1877d36509083bf78203c11893259 
  project/tests/CMakeLists.txt 57948f2811a565ddc8125c3b431c90f5379d87cf 
  shell/CMakeLists.txt 862117e95da9f7502cb6b9a3c992789d4fab88ee 
  shell/kross/xmltokross/CMakeLists.txt a050345be9a07543f2c9934bcaf03ef1764bd790 
  shell/settings/CMakeLists.txt c66367f59c87e698f348d4be483784b08cad674c 
  shell/tests/CMakeLists.txt 79a433f2ae855ca1ac71c7b77e92a518fda65b7d 
  sublime/CMakeLists.txt 49cbd7f4f4bd33d733bc6450011ce9ab77f4f611 
  sublime/examples/CMakeLists.txt b172b3b3672d0a9f9bc4dc090020bdb39b6c2a53 
  sublime/tests/CMakeLists.txt c38d3070d39967903db3e2ec7ddd954b514c4b8b 
  tests/CMakeLists.txt 36d74609d36e6bedeb57d94f30483dffc2a3bd95 
  tests/json/CMakeLists.txt ed33687b20e7f1baab6f808d5a19ea99a76d6b14 
  util/CMakeLists.txt cf2fc1a873ed902dabe65257293532064a9b42da 
  util/dbus_socket_transformer/CMakeLists.txt dc4a61dae11e2abd9bede6089b4f07672173c34e 
  util/duchainify/CMakeLists.txt 40d5144d7ca274673b08556cdc929c3a84221f4c 
  util/ssh_client/CMakeLists.txt d615ab67840759d54c62258e6c3032cf35559d7f 
  util/tests/CMakeLists.txt fb538166e6e8d14cf7c8e473784492bfe27b99e4 
  vcs/CMakeLists.txt e1d935bf222623e24cefb97da72aff7ce33cace4 
  vcs/dvcs/tests/CMakeLists.txt 07f689bd9ef662a2bc4ad86ef028d591b6a3bfe9 
  vcs/models/tests/CMakeLists.txt e6b6942d242ee733378ada9751a08b411a28fe2f 
  vcs/tests/CMakeLists.txt 9cb05773683adf880aa1dd4f0edd3ec2c5c1f47c 

Diff: https://git.reviewboard.kde.org/r/114874/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140105/0c78cc03/attachment.html>

More information about the KDevelop-devel mailing list